From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IGs4P-0007nX-VD for mharc-grub-devel@gnu.org; Fri, 03 Aug 2007 03:59:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IGs4O-0007nR-7l for grub-devel@gnu.org; Fri, 03 Aug 2007 03:59:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IGs4L-0007nF-SM for grub-devel@gnu.org; Fri, 03 Aug 2007 03:59:34 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IGs4L-0007nC-NO for grub-devel@gnu.org; Fri, 03 Aug 2007 03:59:33 -0400 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IGs4L-0001ui-6d for grub-devel@gnu.org; Fri, 03 Aug 2007 03:59:33 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id l737xWZr098613 for ; Fri, 3 Aug 2007 09:59:32 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <871welan0k.fsf@xs4all.nl> <87bqdp942j.fsf@xs4all.nl> <873az18z2n.fsf@xs4all.nl> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 03 Aug 2007 10:01:36 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Fri, 3 Aug 2007 10:06:34 +0800") Message-ID: <87tzrh6o7z.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-Detected-Kernel: FreeBSD 4.6-4.9 Subject: Re: NTFS file system driver (update 4) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2007 07:59:36 -0000 Bean writes: > On 8/3/07, Marco Gerards wrote: >> Bean writes: >> >> >> If you make these two changes and send in the patch, I'll commit the >> >> patch. >> >> >> > >> > Ok, this is the new patch. >> >> Committed. >> > > Thanks, but i don't see fs/ntfs.c in the cvs, do you forget to add it ? Yes, I forgot it, but now it is really committed. > As ntfs driver is done, i start to work on the scripting support. Does > the parser in the previous test program ok ? To be honest, I just didn't find the time yet :(. Actually, I hoped you could first update the other patch regarding scripting. There was one part of the patch I didn't like. If you can take that out, at least the other parts can be committed without much of a problem. About that other parser file? Personally I don't like it if you would start from working from scratch on the parser. The way ASTs and stuff are build now is just fine, although not perfect. However, if you improve the current parsing rules that would be great. I do not have much time today, so if I will not have the time today, I'll try to look after this weekend. -- Marco