From: Marco Gerards <mgerards@xs4all.nl>
To: "Vesa Jääskeläinen" <chaac@nic.fi>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: New patch for video subsystem...
Date: Sun, 12 Mar 2006 15:50:55 +0100 [thread overview]
Message-ID: <87u0a3iunk.fsf@xs4all.nl> (raw)
In-Reply-To: <44085F78.8020409@nic.fi> (Vesa Jääskeläinen's message of "Fri, 03 Mar 2006 17:23:36 +0200")
Vesa Jääskeläinen <chaac@nic.fi> writes:
> Marco Gerards wrote:
>> Vesa Jääskeläinen <chaac@nic.fi> writes:
>>
>> Hi Vesa,
>>
>> Thanks for your patch. I have done a review, but you should know that
>> I am not a graphics expert and don't understand all of the code in
>> detail. Most issues are GCS related, they don't only apply to the
>> line I commented on, but in general. Please make sure all the code is
>> fixed and not this single line.
>
> That wasn't a small job ;).. I hope I got all right.
One more thing... Can you check if the endianess when loading fonts is
converted to the machine endianess? I had some serious doubts that
this was done correctly. This should work, otherwise your code will
seriously break on some archs...
--
Marco
next prev parent reply other threads:[~2006-03-12 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 19:28 New patch for video subsystem Vesa Jääskeläinen
2006-03-03 11:49 ` Marco Gerards
2006-03-03 15:23 ` Vesa Jääskeläinen
2006-03-05 22:25 ` Yoshinori K. Okuji
2006-03-06 19:56 ` Vesa Jääskeläinen
2006-03-09 20:43 ` Vesa Jääskeläinen
2006-03-10 12:21 ` Vesa Jääskeläinen
2006-03-12 14:49 ` Marco Gerards
2006-03-12 21:23 ` Vesa Jääskeläinen
2006-03-14 17:09 ` Vesa Jääskeläinen
2006-03-12 14:50 ` Marco Gerards [this message]
2006-05-04 22:27 ` Johan Rydberg
2006-05-05 8:21 ` Vesa Jääskeläinen
2006-05-05 11:06 ` Johan Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u0a3iunk.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.