From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1FIRuS-0002i3-Ok for mharc-grub-devel@gnu.org; Sun, 12 Mar 2006 09:51:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FIRuR-0002hn-HO for grub-devel@gnu.org; Sun, 12 Mar 2006 09:51:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FIRuP-0002gN-Ks for grub-devel@gnu.org; Sun, 12 Mar 2006 09:51:02 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FIRuP-0002g9-Fo for grub-devel@gnu.org; Sun, 12 Mar 2006 09:51:01 -0500 Received: from [194.109.24.33] (helo=smtp-vbr13.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FIRyA-0000cB-JJ for grub-devel@gnu.org; Sun, 12 Mar 2006 09:54:54 -0500 Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by smtp-vbr13.xs4all.nl (8.13.3/8.13.3) with ESMTP id k2CEot26062165; Sun, 12 Mar 2006 15:50:55 +0100 (CET) (envelope-from mgerards@xs4all.nl) Mail-Copies-To: mgerards@xs4all.nl To: Vesa =?iso-8859-1?Q?J=E4=E4skel=E4inen?= References: <4407474E.6060708@nic.fi> <87y7zrg34j.fsf@xs4all.nl> <44085F78.8020409@nic.fi> From: Marco Gerards Date: Sun, 12 Mar 2006 15:50:55 +0100 In-Reply-To: <44085F78.8020409@nic.fi> (Vesa =?iso-8859-1?Q?J=E4=E4skel=E4?= =?iso-8859-1?Q?inen's?= message of "Fri, 03 Mar 2006 17:23:36 +0200") Message-ID: <87u0a3iunk.fsf@xs4all.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner Cc: The development of GRUB 2 Subject: Re: New patch for video subsystem... X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2006 14:51:03 -0000 Vesa J=E4=E4skel=E4inen writes: > Marco Gerards wrote: >> Vesa J=E4=E4skel=E4inen writes: >>=20 >> Hi Vesa, >>=20 >> Thanks for your patch. I have done a review, but you should know that >> I am not a graphics expert and don't understand all of the code in >> detail. Most issues are GCS related, they don't only apply to the >> line I commented on, but in general. Please make sure all the code is >> fixed and not this single line. > > That wasn't a small job ;).. I hope I got all right. One more thing... Can you check if the endianess when loading fonts is converted to the machine endianess? I had some serious doubts that this was done correctly. This should work, otherwise your code will seriously break on some archs... -- Marco