From: Gerd Knorr <kraxel@suse.de>
To: Scott Parish <srparish@us.ibm.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] alloc_{start,end} truncation
Date: 08 Aug 2005 14:56:02 +0200 [thread overview]
Message-ID: <87u0i0lh99.fsf@bytesex.org> (raw)
In-Reply-To: <20050805175257.GB12423@us.ibm.com>
"Scott Parish" <srparish@us.ibm.com> writes:
> Alloc_{start,end} should be physaddr_t. See attached patch.
Ha, *that* the bug I was hunting as well ;)
> +++ new-xen-pae/xen/arch/x86/domain_build.c 2005-08-05 17:48:07.000000000 +0000
This change looks perfectly fine.
> --- old-xen-pae/xen/include/asm-x86/io.h 2005-07-19 18:51:39.000000000 +0000
> +++ new-xen-pae/xen/include/asm-x86/io.h 2005-08-05 17:45:17.000000000 +0000
> @@ -45,7 +45,7 @@ static inline void * phys_to_virt(unsign
> /*
> * Change "struct pfn_info" to physical address.
> */
> -#ifdef CONFIG_HIGHMEM64G
> +#ifdef CONFIG_TARGET_X86_PAE
That one should be "CONFIG_X86_PAE"
> #define page_to_phys(page) ((u64)(page - frame_table) << PAGE_SHIFT)
But I think even better is to simply drop the ifdef and turn that into
"#define page_to_phys(page) ((physaddr_t)(page - frame_table) << PAGE_SHIFT)"
With these changes in place the dom0 builder survives on my 6GB test
box, now the linux kernel seems to crash early at boot, continuing
debugging ...
Gerd
--
panic("it works"); /* avoid being flooded with debug messages */
next prev parent reply other threads:[~2005-08-08 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 17:52 [PATCH] alloc_{start,end} truncation Scott Parish
2005-08-08 12:56 ` Gerd Knorr [this message]
2005-08-08 14:44 ` Scott Parish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u0i0lh99.fsf@bytesex.org \
--to=kraxel@suse.de \
--cc=srparish@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.