From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DPjxs-00060t-PZ for mharc-grub-devel@gnu.org; Sun, 24 Apr 2005 12:28:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DPjxr-0005zC-2d for grub-devel@gnu.org; Sun, 24 Apr 2005 12:28:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DPjxp-0005yz-Cb for grub-devel@gnu.org; Sun, 24 Apr 2005 12:28:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DPjxp-0005yw-7J for grub-devel@gnu.org; Sun, 24 Apr 2005 12:28:09 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DPjwU-0007U4-1h for grub-devel@gnu.org; Sun, 24 Apr 2005 12:26:46 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 3E52F8777 for ; Sun, 24 Apr 2005 18:19:49 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 29924-01 for ; Sun, 24 Apr 2005 18:19:48 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 0DC7E873F for ; Sun, 24 Apr 2005 18:19:48 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 9A775C046 for ; Sun, 24 Apr 2005 18:19:47 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050422035122.GA12337@miracle> From: Marco Gerards Date: Sun, 24 Apr 2005 18:19:48 +0200 In-Reply-To: <20050422035122.GA12337@miracle> (Hollis Blanchard's message of "Thu, 21 Apr 2005 22:51:22 -0500") Message-ID: <87u0lwrvtn.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [patch] PPC cleanups X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2005 16:28:11 -0000 Hollis Blanchard writes: > This patch has a lot of long-overdue PPC cleanups, including build > warnings. Since we all know the Changelog doesn't explain enough about a > patch, a quick overview: > - include/grub/powerpc/ieee1275/init.h was useless. > - roundup() was unused. > - rather than everyone accessing grub_ieee1275_flags directly, it's now > static and provides test/set accessors. > - grub_ieee1275_realmode should have always been a flag instead of a > global; I don't know what I was thinking at the time. > - ofdisk.h is a now real header (like biosdisk.h); no more > grub_ofdisk_fini/grub_ofdisk_init "missing prototype" warnings. > > Important new functionality: > - actually boot a Linux kernel successfully (don't prematurely free memory) > - properly handle partition numbering on briQ and Pegasos > > I have boot-tested this patch on briQ and G3, and would like to check it > in soon. The patch looks fine to me, although I have a few small comments, see what I write below. This evening I am going to test the patch to see if it works for me. > I also have my sights on include/grub/powerpc/ieee1275/biosdisk.h. Any > suggestions on how to handle using util/i386/pc/biosdisk.c on PPC for > grub-emu? There was a discussion about this before, please read it for details I might have forgotten. But ATM the PC version works for the PPC as well. There is no platform specific code there yet and I want to keep things shared as long as it is possible. Doesn't it work for you or are there any issues? The biosdisk code is the code, together with the i386 specific code, I am the least familiar with. > 2005-04-21 Hollis Blanchard > * disk/powerpc/ieee1275/ofdisk.c: Include grub/machine/ofdisk.h. Don't > include grub/machine/init.h. Two spaces are required here, please fix this in the other places in the changelog entry/comments as well. > * include/grub/powerpc/ieee1275/ieee1275.h (grub_ieee1275_flags): > Remove prototype. > (grub_ieee1275_realmode): Likewise. > (grub_ieee1275_flag): New enum. Can you give the enums a prefix? For example `GRUB_IEEE1275_NO_PARTITION_0' can be changed to `GRUB_IEEE1275_FLAGS_NO_PARTITION_0'. > * kern/powerpc/ieee1275/init.c: Don't include grub/machine/init.h. > Include grub/machine/console.h. Include grub/machine/ofdisk.h. > (abort): Correct whitespace. Huh? What is this whitespace change? And there is no need to mention it in the changelog in case it is required. -- Marco