From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1COuDQ-0005w4-CV for mharc-grub-devel@gnu.org; Tue, 02 Nov 2004 03:40:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COuDN-0005ue-Li for grub-devel@gnu.org; Tue, 02 Nov 2004 03:40:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COuDM-0005tx-Tt for grub-devel@gnu.org; Tue, 02 Nov 2004 03:40:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COuDM-0005tG-98 for grub-devel@gnu.org; Tue, 02 Nov 2004 03:40:28 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1COu5I-0002tA-IF for grub-devel@gnu.org; Tue, 02 Nov 2004 03:32:08 -0500 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id CDF208446 for ; Tue, 2 Nov 2004 09:25:32 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 24849-06 for ; Tue, 2 Nov 2004 09:25:29 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 445278BFE for ; Tue, 2 Nov 2004 09:25:27 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 30869C047 for ; Tue, 2 Nov 2004 09:25:26 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <238F4F30-2C82-11D9-8335-000A95A0560C@penguinppc.org> From: Marco Gerards Date: Tue, 02 Nov 2004 09:25:28 +0000 In-Reply-To: <238F4F30-2C82-11D9-8335-000A95A0560C@penguinppc.org> (Hollis Blanchard's message of "Mon, 1 Nov 2004 21:49:03 -0600") Message-ID: <87u0s8eh6f.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: partition map reorganization X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 08:40:30 -0000 Hollis Blanchard writes: > I'm working on supporting more than one partition map per > architecture. Currently, x86 builds use disk/i386/pc/partition.c, and > PPC builds use disk/powerpc/ieee1275/partition.c. Both provide > identically-named functions for architecture-neutral code > (e.g. grub_partition_iterate). Additionally, Apple partition code > deals with things it shouldn't (e.g. dos_type), so we can see that > some abstraction is needed here. Thanks for working on this. I planned to do this, but as you might have noticed I did not have much time for working on GRUB 2 lately. At the moment I do not have time to read your entire email and comment on that, I will do that this evening. Please make sure that for every partition type the endian is converted to the host endian. > In order to support both partition types (and potentially more, should > the need arise) in the same binary, I'm introducing a "partition_ops" > structure to struct grub_disk, which contains a couple function > pointers that are set as appropriate at grub_disk_open time. There is > one ops structure per partition map type (i.e. DOS and Apple right > now). Does this mean it will be possible to create modules for partitions? For example applepartmap.mod or so. This is really important to me. > It's not all ready for submission yet, but the struct division could > go in first, to try to commit smaller incremental patches rather than > one massive one. Is this ok? Both ways are fine to me. Thanks, Marco