From: Markus Armbruster <armbru@pond.sub.org>
To: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Subject: Re: python/qemu/ too picky with QMP responses?
Date: Wed, 18 Nov 2026 19:21:36 +0100 [thread overview]
Message-ID: <87v75udmq7.fsf@pond.sub.org> (raw)
In-Reply-To: <87bj7mioch.fsf@pond.sub.org> (Markus Armbruster's message of "Wed, 18 Nov 2026 08:35:26 +0100")
Markus Armbruster <armbru@pond.sub.org> writes:
> Marc-André and I broke python/qemu/utils/qom_common.py in commit
> 0eee31cf1085 (qapi/qom: add qapi-type to qom-list, qom-list-properties,
> qom-list-get):
[...]
> The first assertion checks we got the members we actually require.
>
> The second assertion checks we got no members we don't know.
>
> The commit I quoted added member @qapi-type without updating the second
> assertion.
>
> Adding it to the set of members we know would be easy enough. But is it
> appropriate? docs/devel/qapi-code-gen.rst section "Compatibility
> considerations":
>
> Clients are expected to ignore [members] they don't know.
>
> Shouldn't we do that here?
>
> Any objections to me hunting down and deleting such assertions?
Just sent:
Subject: [PATCH] python/qemu: Don't choke on unknown members in QMP replies
Date: Wed, 18 Nov 2026 19:20:05 +0100
Message-ID: <20261118182005.1066151-1-armbru@redhat.com>
prev parent reply other threads:[~2026-11-18 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 7:35 python/qemu/ too picky with QMP responses? Markus Armbruster
2026-11-18 18:21 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v75udmq7.fsf@pond.sub.org \
--to=armbru@pond.sub.org \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.