All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/xe/lrc: Fix math in LRC offset comments
Date: Tue, 17 Nov 2026 09:49:13 -0300	[thread overview]
Message-ID: <87v75v7hdi.fsf@intel.com> (raw)
In-Reply-To: <20261116225052.1167601-2-matthew.d.roper@intel.com>

Matt Roper <matthew.d.roper@intel.com> writes:

> PREEMPTION_STATUS in the Xe2 RCS LRC starts at offset 0x39 and requires
> two dwords of space (offset + value), so the next item in the LRC starts
> at 0x3b, not 0x41 (it appears the number was treated as decimal rather
> than hex when the comment was first written).  Adjust the remaining
> offset comments to show the proper values.
>
> No functional impact; these comments are just for convenience and don't
> relate to any in-driver logic.
>
> Bspec: 65182
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_lrc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 8e4f767d7f59..54d50b1b28eb 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -563,9 +563,9 @@ static const u8 xe2_rcs_offsets[] = {
>  	REG16(0x5a8),           /* [0x37] CONTEXT_SCHEDULING_ATTRIBUTES */
>  	REG16(0x5ac),           /* [0x39] PREEMPTION_STATUS */
>  
> -	NOP(6),                 /* [0x41] */
> -	LRI(1, 0),              /* [0x47] */
> -	REG(0x0c8),             /* [0x48] R_PWR_CLK_STATE */
> +	NOP(6),                 /* [0x3b] */
> +	LRI(1, 0),              /* [0x41] */
> +	REG(0x0c8),             /* [0x42] R_PWR_CLK_STATE */
>  
>  	0
>  };
> -- 
> 2.43.0

  parent reply	other threads:[~2026-11-17 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:50 [PATCH] drm/xe/lrc: Fix math in LRC offset comments Matt Roper
2026-11-16 23:16 ` ✓ CI.KUnit: success for " Patchwork
2026-11-16 23:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17 12:49 ` Gustavo Sousa [this message]
2026-11-17 13:05 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-11-17 18:16   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v75v7hdi.fsf@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.