From: Takashi Iwai <tiwai@suse.de>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: ump: Fix dropped data bytes at UMP System message conversion
Date: Sat, 31 Oct 2026 17:03:58 +0100 [thread overview]
Message-ID: <87v76hrh5d.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261029130538.1985867-1-sammiee5311@gmail.com>
On Thu, 29 Oct 2026 14:05:37 +0100,
HyeongJun An wrote:
>
> The cvt_ump_system_to_legacy() function switches on
> ump_message_status_code(), which returns only the upper 4 bits of the
> status. The case labels are the full 0xf1, 0xf2 and 0xf3 values, so they
> never match. MIDI Time Code, Song Position and Song Select are converted
> to the status byte alone, and their data bytes are lost.
>
> Switch on the full status byte in buf[0] instead.
>
> Both callers of snd_ump_convert_from_ump() pass the result on as is: the
> legacy rawmidi input of a UMP endpoint, and the MIDI 1.0 path of the
> f_midi2 USB gadget.
>
> Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
> Cc: stable@vger.kernel.org
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-31 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 13:05 [PATCH] ALSA: ump: Fix dropped data bytes at UMP System message conversion HyeongJun An
2026-10-31 16:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v76hrh5d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sammiee5311@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.