Re: [Buildroot] [PATCH 1/2] package/pkg-hare: refactor build command

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > In order to avoid duplicating the build command, use an intermediate
 > "target" shell variable to store the make target to be invoked for the
 > build. This is in preparation to extending the build command.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 >  package/pkg-hare.mk | 7 +++----
 >  1 file changed, 3 insertions(+), 4 deletions(-)

 > diff --git a/package/pkg-hare.mk b/package/pkg-hare.mk
 > index 14e0cfce5a..15dc769311 100644
 > --- a/package/pkg-hare.mk
 > +++ b/package/pkg-hare.mk
 > @@ -49,10 +49,9 @@ ifndef $(2)_BUILD_CMDS
 >  # but in real world, the target "all" is not always the default one
 >  define $(2)_BUILD_CMDS
 >  	if grep "^all:" $$($(2)_SRCDIR)Makefile > /dev/null; then \
 > -		$(MAKE) -C $$($(2)_SRCDIR) HARE="$$(HARE_RUN_CMD)" HAREFLAGS="$$(HARE_ARCH_OPT) $$(HARE_LIBDIR_OPT)" all; \
 > -	else \
 > -		$(MAKE) -C $$($(2)_SRCDIR) HARE="$$(HARE_RUN_CMD)" HAREFLAGS="$$(HARE_ARCH_OPT) $$(HARE_LIBDIR_OPT)"; \
 > -	fi
 > +		target=all ; \
 > +	fi ; \
 > +	$(MAKE) -C $$($(2)_SRCDIR) HARE="$$(HARE_RUN_CMD)" HAREFLAGS="$$(HARE_ARCH_OPT) $$(HARE_LIBDIR_OPT)" $${target}

I already pushed, but this presumably will break quite badly if someone
has a 'target' environment variable set. Maybe we should explicitly set
it to the empty string in the else clause?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot