All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tarun Noonemunthala <ntarun2000@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for HP ENVY 13-aq1xxx
Date: Mon, 28 Sep 2026 13:36:57 +0200	[thread overview]
Message-ID: <87v77p6206.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260923094014.58867-1-ntarun2000@gmail.com>

On Wed, 23 Sep 2026 11:40:14 +0200,
Tarun Noonemunthala wrote:
> 
> The HP ENVY Laptop 13-aq1xxx (PCI SSID 103c:86ad) uses an ALC285 codec
> with two speaker pairs: front (pin 0x14) and bottom (pin 0x17).
> 
> The BIOS leaves pin 0x14 as [N/A] ("not connected"), so the generic
> parser never enables the front pair and only the bottom speakers are
> audible.  The vendor driver (RTKVHD64.sys) programs that pin with the
> value 0x90170150 and runs the HP amplifier initialization, which is
> already implemented in the driver as ALC285_FIXUP_HP_GPIO_AMP_INIT.
> 
> Add a board fixup that applies the pin configuration for 0x14 and chains
> to the existing amplifier init fixup.
> 
> The pin value was recovered from the vendor driver's own configuration
> data.  The patch and this changelog were prepared with an AI coding
> assistant (see the Assisted-by tag below); the change was reviewed and
> tested by the submitter on the affected machine.
> 
> Tested on an HP ENVY 13-aq1xxx by rebuilding snd-hda-codec-alc269 from
> the Fedora 7.1.10 source and loading it: the codec now reports
> "line_outs=2 (0x14/0x17)", pin 0x14 comes up as an output (Pin-ctls
> 0x40) with its amplifier unmuted, and both speaker pairs play.
> 
> Assisted-by: OpenCode:deepseek-v4.1-flash checkpatch
> Signed-off-by: Tarun Noonemunthala <ntarun2000@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-09-28 11:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  9:40 [PATCH] ALSA: hda/realtek: Add quirk for HP ENVY 13-aq1xxx Tarun Noonemunthala
2026-09-28 11:36 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v77p6206.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=ntarun2000@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.