From: Miquel Raynal <miquel.raynal@bootlin.com>
To: <Takahiro.Kuwano@infineon.com>
Cc: <mwalle@kernel.org>, <pratyush@kernel.org>, <richard@nod.at>,
<vigneshr@ti.com>, <linux-mtd@lists.infradead.org>
Subject: Re: Sashiko to track linux-mtd
Date: Tue, 25 Aug 2026 11:25:38 +0200 [thread overview]
Message-ID: <87v78yimb1.fsf@bootlin.com> (raw)
In-Reply-To: <8733xhiqyn.fsf@bootlin.com> (Miquel Raynal's message of "Fri, 17 Jul 2026 17:19:28 +0200")
Hello,
On 17/07/2026 at 17:19:28 +02, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hello folks,
>
>> So I will make a PR for enabling it, but let's keep in mind that this is
>> experimental and can be re-discussed at any time.
>
> FYI: https://github.com/sashiko-dev/sashiko/pull/336
I am partially satisfied about how Sashiko intervenes in my review
flow, here is my current feeling.
About Sashiko itself:
+ many interesting findings, worth enabling for sure
+ most of the findings are correct, but not always worth another version
- no possible feedback loop (eg. "this is an hallucination, stop
bothering us with this")
- pre-existing issues are flagged at the same "level" as new issues
About our configuration of Sashiko:
- it takes more time to me to do the check, copy & paste dance every
time there is something I find really needed
- I get Cc'ed on reviews of patches I did not receive (eg. jffs2 things)
In the end I would like to modify the current configuration in order for
Sashiko to act as a regular reviewer, ie. just answer to all recipients,
including the author:
- cc = ...
+ reply_all = true
+ reply_to_author = true
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-08-25 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 7:42 Sashiko to track linux-mtd Miquel Raynal
2026-06-24 8:57 ` Pratyush Yadav
2026-06-29 15:12 ` Miquel Raynal
2026-07-01 7:32 ` Michael Walle
2026-07-10 2:55 ` Takahiro.Kuwano
2026-07-17 9:16 ` Miquel Raynal
2026-07-17 15:19 ` Miquel Raynal
2026-08-25 9:25 ` Miquel Raynal [this message]
2026-08-25 9:58 ` Michael Walle
2026-08-28 5:59 ` Takahiro.Kuwano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v78yimb1.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.