From: Takashi Iwai <tiwai@suse.de>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: ump: Fix corrupted data bytes at MIDI 1.0 SysEx to UMP conversion
Date: Sat, 08 Aug 2026 09:01:51 +0200 [thread overview]
Message-ID: <87v79l9jts.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260808014554.3550153-1-sammiee5311@gmail.com>
On Sat, 08 Aug 2026 03:45:54 +0200,
HyeongJun An wrote:
>
> The cvt_legacy_sysex_to_ump() initialises only the first word of the
> output packet and ORs the data bytes into it. The second word is left
> alone, and the conversion context is kept across calls, so it still
> carries the previous packet's bytes. Those stale bits corrupt the new
> data. Any SysEx longer than six data bytes is affected.
>
> A SysEx with the twelve data bytes 01..0c comes out as:
>
> 30160102 03040506
> 30260708 0b0e0f0e
>
> The second packet declares six data bytes and four of them are wrong,
> inside the declared length.
>
> The sibling cvt_legacy_cmd_to_ump() already clears the second word. Do
> the same here.
>
> Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
> Cc: stable@vger.kernel.org
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-08-08 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 1:45 [PATCH] ALSA: ump: Fix corrupted data bytes at MIDI 1.0 SysEx to UMP conversion HyeongJun An
2026-08-08 7:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v79l9jts.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sammiee5311@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.