Re: [PATCH v2 5/7] clk: Use the generic OF phandle parsing in only one place

[Miquel Raynal <miquel.raynal@bootlin.com>]

On 10/07/2026 at 18:36:49 GMT, sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] Switching to `of_parse_clkspec` breaks out-of-bounds indexed
> clock lookups on nodes with `clock-ranges`, causing infinite loops and
> topology corruption.
> - [High] API mismatch between `of_clk_get_parent_name` and
> `of_clk_get_parent_count` regarding `clock-ranges` support.

These two issues are related, I feel like it is best to make sure that
the semantics do not change, which is doable by making sure we do not
loop over the parents when unnecessary, which avoids the possible
out-of-bounds indexing and the API mismatch.

Said otherwise, in of_parse_clkspec() we may check the presence of the
`clocks` property when looking up clks. If the `clocks` property is
there, either we find the clock, or if we get an error it means we are
out of bounds and can return early. If the `clocks` property is not
present, this is when the clock-ranges property may be useful and when
checking the parent is relevant (normal case).

Thanks,
Miquèl