Re: [PATCH 8/9] hw/i386/pc_sysfw.c: convert pflash0 and pflash1 object props to class props

[Markus Armbruster <armbru@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Wed, 8 Jul 2026 at 13:57, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Daniel P. Berrangé <berrange@redhat.com> writes:
>>
>> > On Wed, Jul 08, 2026 at 02:50:54PM +0200, Markus Armbruster wrote:
>> >> > Something would need to validate that instantiating a machine type
>> >> > for help usage won't trip over any edge cases. Could be done with
>> >> > unit tests.
>> >>
>> >> tests/qtest/device-introspect-test.c covers this for devices.
>> >
>> > Ah, good, I was misled by its name into thinking it was only devices,
>> > not machine types too.
>>
>> Misunderstanding: it does cover it for devices, and only for devices.
>
> Does Marc-André's recent qom-tests test cover the machines? It
> does an instantiate/get props/unref cycle for all non-abstract
> QOM types, which ought to include the machines.

I guess you mean commit f741225073 (qtest: add "qom-tests" command,
2026-04-24).  Looking at the code...  yes, that should cover machines.

> A while back I had a look at moving Machine to be a subclass
> of Device, incidentally -- that would let us have machine
> reset not be a weird special case, allow separating machine
> init from realize, and make machines be more like SoC objects
> (which they resemble a lot in being "creates, configures
> and wires up a load of other devices").

Makes sense to me.

>                                         I forget where I
> got to in that, though.

Been there, done that *sigh*.