From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE6084A33F2; Thu, 2 Jul 2026 13:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782999696; cv=none; b=kpp6j7N+3LuvJmFn76cHwexkPFenV4ZvXKk9on6qqu5KIV+fe8V3cu29HHFh26wOczogxeSPi1UXNRUuneBnAoHwginTH3xoNBvtP5FGe+JZGJ24oHst/vqfGVuTulRSh/Nl8zdY7ZToacMVq76IJmD9Ec9A1pKursZ9xGortI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782999696; c=relaxed/simple; bh=3NlBw7T5nabuhOxxhmeklPLxyEetO10ugW8lwBtpDek=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cm4fX96qX/8yZ6tI9eNodi4ixV8dtJB7Z136mlC1uQ0ES+g/4fgGPq42CBog65VQlC+MrjxS7Vmf/yYmrP1PbM7lFYmIFD9b2vGUZHaBBqhvddGd0OocMFVJJwZ/rAZJ/GxgyKt/XatQqVwWURKK0/iNULiryG2lUNuvXmwdN9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=tbkQTnk/; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="tbkQTnk/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 44C8C1A0DE7; Thu, 2 Jul 2026 13:41:32 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 11DAB5FF03; Thu, 2 Jul 2026 13:41:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 932EC104C9577; Thu, 2 Jul 2026 15:41:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782999691; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=3kbHnC3x3hEpbNdF+qEJ6jzcXt/7SmkG5FNSavJE8Ds=; b=tbkQTnk/xbfoAM1MziLjXUidjKag65lxh3C+w2AFcWUZt8jrhqRqMPrg+jKMq44qEJjJ/3 S58xyi4QHP3dVJpYcHhRSTg5RB7KbihIDrQ5kmQtOldRZ1FoU2LtPDRUs+ga2ePuqILrpu HXGE46szPIgoxkCSgPain7ryJrFwd0w0MVqwbdI6hw0VKdIw8gxKybMWbny+XRNdvKVnJq wqSw7Fcd41VTUVWDrj2UsLksij0fbna6g8CZOSGP7/kam31vZTd3uKs2SYaI6mBZON3mON C0/YkQEIrUlgE1+SjUoeisGO3DLktE99SA+6cmrFuolFSxK9mR/L/2k89ng8ZQ== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 13/16] mtd: spinand: extract variant ranking logic into spinand_op_find_best() In-Reply-To: <20260618073725.84733-14-s-k6@ti.com> (Santhosh Kumar K.'s message of "Thu, 18 Jun 2026 13:07:22 +0530") References: <20260618073725.84733-1-s-k6@ti.com> <20260618073725.84733-14-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 02 Jul 2026 15:41:27 +0200 Message-ID: <87v7axpkzc.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 18/06/2026 at 13:07:22 +0530, Santhosh Kumar K wrote: > spinand_select_op_variant() open-codes a loop that finds the fastest > eligible op variant by transfer duration. Extract this into a shared > helper spinand_op_find_best() that accepts a skip_mask bitmask of > already-tried variant indices, enabling callers to iterate variants in > ranked order while skipping previously attempted ones. > > spinand_select_op_variant() becomes a one-liner. No functional change. > > Signed-off-by: Santhosh Kumar K > --- > drivers/mtd/nand/spi/core.c | 32 +++++++++++++++++++++++++++----- > 1 file changed, 27 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index f86786344d52..b678d0534297 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -1541,9 +1541,22 @@ static int spinand_init_odtr_instruction_set(struc= t spinand_device *spinand) > return 0; > } >=20=20 > +/* > + * spinand_op_find_best() - Find the fastest eligible op variant. Should definitely be named spinand_op_find_best_variant(). find_best is way too wide. > + * @spinand: SPI NAND device > + * @variants: full variant list to search > + * @odtr: true to consider ODTR ops, false for SSDR ops > + * @skip_mask: bitmask of variant indices to skip (already tried) The flag seems to be quite overlapping with the odtr flag. Shouldn't we have a single way to filter operations? Also, why are you switching from an interface enumeration to a boolean? Some day we might need to support things like 4D-4D-4D. That is where an enumeration is better than a boolean. If you want to drop the enumeration, it shall be done everywhere else, but I don't think it is a good approach. > + * Iterates @variants, evaluates transfer duration for each eligible op,= and > + * returns a pointer to the fastest one not in @skip_mask. Returns NULL= when > + * no eligible variant remains. Used by both variant selection at init = time > + * (skip_mask =3D=3D 0) and ranked PHY tuning iteration. > + */ I haven't seen what is the use case of this mask yet, let's see in the following patches. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E39DCC43458 for ; Thu, 2 Jul 2026 13:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kDkUPTDSdX/M80aPszwc+hA4hJ6B2I9RN+ADc+f54Wc=; b=Oh8xd88FJ5MVQw FtWFfuLhfGzP1DPdlRN1MRuoxUyYf70wWsTC7+xCM3nZDZ/617P0qqwgjOSVybrRjBzr7QcxvdadW SEBy9pWtmUGIyU7ctUFmknCqoW/UIq1VRzNZZqnf6vff3xJnpFNo3FrTe1P2AAa0K6stOGUwqTOzH Y7alGmwIrTFfiuigZZl3QmjlGIGtwP3kC5F61B/se2Dcw4d9ZNIGfqyW+QXnXEzC3RS6kHw4aV7jQ 6WRS92+xHOd3JsnywKvW9M9LtztbAdFb7iZFcW/iRqBxIRb0jfjDh6Ufu2NnykhDQTxcJ+C6OLhzJ f4jxWtEGACfNHa/wnJmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfHfe-00000004Y6L-0gFg; Thu, 02 Jul 2026 13:41:38 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfHfa-00000004Y5K-1xOw for linux-mtd@lists.infradead.org; Thu, 02 Jul 2026 13:41:36 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 7044BC4FEDD; Thu, 2 Jul 2026 13:41:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 11DAB5FF03; Thu, 2 Jul 2026 13:41:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 932EC104C9577; Thu, 2 Jul 2026 15:41:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782999691; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=3kbHnC3x3hEpbNdF+qEJ6jzcXt/7SmkG5FNSavJE8Ds=; b=tbkQTnk/xbfoAM1MziLjXUidjKag65lxh3C+w2AFcWUZt8jrhqRqMPrg+jKMq44qEJjJ/3 S58xyi4QHP3dVJpYcHhRSTg5RB7KbihIDrQ5kmQtOldRZ1FoU2LtPDRUs+ga2ePuqILrpu HXGE46szPIgoxkCSgPain7ryJrFwd0w0MVqwbdI6hw0VKdIw8gxKybMWbny+XRNdvKVnJq wqSw7Fcd41VTUVWDrj2UsLksij0fbna6g8CZOSGP7/kam31vZTd3uKs2SYaI6mBZON3mON C0/YkQEIrUlgE1+SjUoeisGO3DLktE99SA+6cmrFuolFSxK9mR/L/2k89ng8ZQ== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 13/16] mtd: spinand: extract variant ranking logic into spinand_op_find_best() In-Reply-To: <20260618073725.84733-14-s-k6@ti.com> (Santhosh Kumar K.'s message of "Thu, 18 Jun 2026 13:07:22 +0530") References: <20260618073725.84733-1-s-k6@ti.com> <20260618073725.84733-14-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 02 Jul 2026 15:41:27 +0200 Message-ID: <87v7axpkzc.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_064134_671291_A1B9F778 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTgvMDYvMjAyNiBhdCAxMzowNzoyMiArMDUzMCwgU2FudGhvc2ggS3VtYXIgSyA8cy1rNkB0 aS5jb20+IHdyb3RlOgoKPiBzcGluYW5kX3NlbGVjdF9vcF92YXJpYW50KCkgb3Blbi1jb2RlcyBh IGxvb3AgdGhhdCBmaW5kcyB0aGUgZmFzdGVzdAo+IGVsaWdpYmxlIG9wIHZhcmlhbnQgYnkgdHJh bnNmZXIgZHVyYXRpb24uIEV4dHJhY3QgdGhpcyBpbnRvIGEgc2hhcmVkCj4gaGVscGVyIHNwaW5h bmRfb3BfZmluZF9iZXN0KCkgdGhhdCBhY2NlcHRzIGEgc2tpcF9tYXNrIGJpdG1hc2sgb2YKPiBh bHJlYWR5LXRyaWVkIHZhcmlhbnQgaW5kaWNlcywgZW5hYmxpbmcgY2FsbGVycyB0byBpdGVyYXRl IHZhcmlhbnRzIGluCj4gcmFua2VkIG9yZGVyIHdoaWxlIHNraXBwaW5nIHByZXZpb3VzbHkgYXR0 ZW1wdGVkIG9uZXMuCj4KPiBzcGluYW5kX3NlbGVjdF9vcF92YXJpYW50KCkgYmVjb21lcyBhIG9u ZS1saW5lci4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBTYW50aG9z aCBLdW1hciBLIDxzLWs2QHRpLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvY29y ZS5jIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDI3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tdGQvbmFuZC9zcGkvY29yZS5jIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5jCj4g aW5kZXggZjg2Nzg2MzQ0ZDUyLi5iNjc4ZDA1MzQyOTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9t dGQvbmFuZC9zcGkvY29yZS5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5jCj4g QEAgLTE1NDEsOSArMTU0MSwyMiBAQCBzdGF0aWMgaW50IHNwaW5hbmRfaW5pdF9vZHRyX2luc3Ry dWN0aW9uX3NldChzdHJ1Y3Qgc3BpbmFuZF9kZXZpY2UgKnNwaW5hbmQpCj4gIAlyZXR1cm4gMDsK PiAgfQo+ICAKPiArLyoKPiArICogc3BpbmFuZF9vcF9maW5kX2Jlc3QoKSAtIEZpbmQgdGhlIGZh c3Rlc3QgZWxpZ2libGUgb3AgdmFyaWFudC4KClNob3VsZCBkZWZpbml0ZWx5IGJlIG5hbWVkIHNw aW5hbmRfb3BfZmluZF9iZXN0X3ZhcmlhbnQoKS4gZmluZF9iZXN0IGlzCndheSB0b28gd2lkZS4K Cj4gKyAqIEBzcGluYW5kOiAgICBTUEkgTkFORCBkZXZpY2UKPiArICogQHZhcmlhbnRzOiAgIGZ1 bGwgdmFyaWFudCBsaXN0IHRvIHNlYXJjaAo+ICsgKiBAb2R0cjogICAgICAgdHJ1ZSB0byBjb25z aWRlciBPRFRSIG9wcywgZmFsc2UgZm9yIFNTRFIgb3BzCj4gKyAqIEBza2lwX21hc2s6ICBiaXRt YXNrIG9mIHZhcmlhbnQgaW5kaWNlcyB0byBza2lwIChhbHJlYWR5IHRyaWVkKQoKVGhlIGZsYWcg c2VlbXMgdG8gYmUgcXVpdGUgb3ZlcmxhcHBpbmcgd2l0aCB0aGUgb2R0ciBmbGFnLiBTaG91bGRu J3Qgd2UKaGF2ZSBhIHNpbmdsZSB3YXkgdG8gZmlsdGVyIG9wZXJhdGlvbnM/CgpBbHNvLCB3aHkg YXJlIHlvdSBzd2l0Y2hpbmcgZnJvbSBhbiBpbnRlcmZhY2UgZW51bWVyYXRpb24gdG8gYSBib29s ZWFuPwpTb21lIGRheSB3ZSBtaWdodCBuZWVkIHRvIHN1cHBvcnQgdGhpbmdzIGxpa2UgNEQtNEQt NEQuIFRoYXQgaXMgd2hlcmUgYW4KZW51bWVyYXRpb24gaXMgYmV0dGVyIHRoYW4gYSBib29sZWFu LiBJZiB5b3Ugd2FudCB0byBkcm9wIHRoZQplbnVtZXJhdGlvbiwgaXQgc2hhbGwgYmUgZG9uZSBl dmVyeXdoZXJlIGVsc2UsIGJ1dCBJIGRvbid0IHRoaW5rIGl0IGlzIGEKZ29vZCBhcHByb2FjaC4K Cj4gKyAqIEl0ZXJhdGVzIEB2YXJpYW50cywgZXZhbHVhdGVzIHRyYW5zZmVyIGR1cmF0aW9uIGZv ciBlYWNoIGVsaWdpYmxlIG9wLCBhbmQKPiArICogcmV0dXJucyBhIHBvaW50ZXIgdG8gdGhlIGZh c3Rlc3Qgb25lIG5vdCBpbiBAc2tpcF9tYXNrLiAgUmV0dXJucyBOVUxMIHdoZW4KPiArICogbm8g ZWxpZ2libGUgdmFyaWFudCByZW1haW5zLiAgVXNlZCBieSBib3RoIHZhcmlhbnQgc2VsZWN0aW9u IGF0IGluaXQgdGltZQo+ICsgKiAoc2tpcF9tYXNrID09IDApIGFuZCByYW5rZWQgUEhZIHR1bmlu ZyBpdGVyYXRpb24uCj4gKyAqLwoKSSBoYXZlbid0IHNlZW4gd2hhdCBpcyB0aGUgdXNlIGNhc2Ug b2YgdGhpcyBtYXNrIHlldCwgbGV0J3Mgc2VlIGluIHRoZQpmb2xsb3dpbmcgcGF0Y2hlcy4KClRo YW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K