From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E58F5CD6E55 for ; Wed, 3 Jun 2026 15:55:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUnw2-0000dV-Df; Wed, 03 Jun 2026 11:55:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUnw0-0000cK-M6 for qemu-devel@nongnu.org; Wed, 03 Jun 2026 11:55:12 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wUnvx-0000dJ-47 for qemu-devel@nongnu.org; Wed, 03 Jun 2026 11:55:12 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F4166A94A; Wed, 3 Jun 2026 15:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780502107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUd5D9UzfrzB7oiBYYYk2EZg4Z6Zg+qTE47rjbkErLU=; b=d+r52eWM2lZpxBFFLxChJd5A6Cy88gsd14q2efmFtCv3oyKOlWvBprllx4YS8LrcTWTNRA rg4f43LqHjyyHf6ueDKI1h77jLbDB9aictxaggVXlRllF/Hgfvauh1U6J5f3tcHvMr8ebQ 41inD7EsRAbWJOG2jdurL0BaNMy39+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780502107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUd5D9UzfrzB7oiBYYYk2EZg4Z6Zg+qTE47rjbkErLU=; b=+qdgqxFZlBtuxfUyMnm1LUht9Zbxbj0lje7rHdVuyoT9IimJMGhGJ3VUoOrizJtLeNamyI HMpoCQqrmbPPLpAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d+r52eWM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+qdgqxFZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780502107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUd5D9UzfrzB7oiBYYYk2EZg4Z6Zg+qTE47rjbkErLU=; b=d+r52eWM2lZpxBFFLxChJd5A6Cy88gsd14q2efmFtCv3oyKOlWvBprllx4YS8LrcTWTNRA rg4f43LqHjyyHf6ueDKI1h77jLbDB9aictxaggVXlRllF/Hgfvauh1U6J5f3tcHvMr8ebQ 41inD7EsRAbWJOG2jdurL0BaNMy39+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780502107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUd5D9UzfrzB7oiBYYYk2EZg4Z6Zg+qTE47rjbkErLU=; b=+qdgqxFZlBtuxfUyMnm1LUht9Zbxbj0lje7rHdVuyoT9IimJMGhGJ3VUoOrizJtLeNamyI HMpoCQqrmbPPLpAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D5B70779A7; Wed, 3 Jun 2026 15:55:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +RxaKVpOIGr8UAAAD6G6ig (envelope-from ); Wed, 03 Jun 2026 15:55:06 +0000 From: Fabiano Rosas To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, Paolo Bonzini Subject: Re: [PATCH] chardev: Don't unregister yank upon async path connection failure In-Reply-To: References: <20260603141137.1108963-1-farosas@suse.de> Date: Wed, 03 Jun 2026 12:55:00 -0300 Message-ID: <87v7bz7h63.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[gitlab.com:url,suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3F4166A94A Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Marc-Andr=C3=A9 Lureau writes: > On Wed, Jun 3, 2026 at 6:11=E2=80=AFPM Fabiano Rosas wr= ote: >> >> Commit 5c102ac9 ("chardev: Consolidate yank registration") has moved >> yank registration in the tcp_chr_connect_client_async() path to after >> the connection is successful. If qio_channel_socket_connect_sync() >> fails early, there will be no yank registered to be unregistered in >> the error path, leading to assert. >> >> Remove the now-extraneous unregister. >> >> Cc: qemu-stable@nongnu.org >> Fixes: 5c102ac9 ("chardev: Consolidate yank registration") >> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3528 >> Signed-off-by: Fabiano Rosas >> --- >> chardev/char-socket.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/chardev/char-socket.c b/chardev/char-socket.c >> index e064b105c5..99e01a4875 100644 >> --- a/chardev/char-socket.c >> +++ b/chardev/char-socket.c >> @@ -1128,11 +1128,6 @@ static void qemu_chr_socket_connected(QIOTask *ta= sk, void *opaque) >> >> if (qio_task_propagate_error(task, &err)) { >> tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED); >> - if (s->registered_yank) { > > Is "registered_yank" stalled too? shouldn't be set to false to avoid > that path and possibly others? > No because registered_yank is about the YankInstance. There's no actual tracking of the individual YankFns. >> - yank_unregister_function(CHARDEV_YANK_INSTANCE(chr->label), >> - char_socket_yank_iochannel, >> - QIO_CHANNEL(sioc)); >> - } >> check_report_connect_error(chr, err); >> goto cleanup; >> } >> -- >> 2.53.0 >>