From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7C89FAD40B for ; Thu, 23 Apr 2026 05:03:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFmD0-00036f-Ei; Thu, 23 Apr 2026 01:02:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFmCi-00035s-Mp for qemu-devel@nongnu.org; Thu, 23 Apr 2026 01:02:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFmCh-0007OK-0I for qemu-devel@nongnu.org; Thu, 23 Apr 2026 01:02:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776920536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yFCd+gBtlVaNXTSSuckob3QlPY5VzhH/HBlQlwUbNA=; b=TLtiwzSrRct4k48xsekbadax+IN7DcxHplBZ0A6e3M8A9HTBGLblURGBJp/wpye9maRu/n EmwrW/c8VgJHQ6Ds5SfGK9QeK7xHDB8QOtezLhyKPS3lkbIKkJnv+7cJGmXLJWor+2j05w RLQ9h+G3y7gn/i+ZqhoOUOeW/0Gad9M= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-GRUEQKxTOvid9SPFEGabHw-1; Thu, 23 Apr 2026 01:02:15 -0400 X-MC-Unique: GRUEQKxTOvid9SPFEGabHw-1 X-Mimecast-MFC-AGG-ID: GRUEQKxTOvid9SPFEGabHw_1776920534 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A40F195605F for ; Thu, 23 Apr 2026 05:02:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.30]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 032AA180045E for ; Thu, 23 Apr 2026 05:02:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 49F7221E6A28; Thu, 23 Apr 2026 07:02:11 +0200 (CEST) From: Markus Armbruster To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] ui/console: remove console from global list on finalization In-Reply-To: <20260422202646.272081-1-marcandre.lureau@redhat.com> (marcandre lureau's message of "Thu, 23 Apr 2026 00:26:46 +0400") References: <20260422202646.272081-1-marcandre.lureau@redhat.com> Date: Thu, 23 Apr 2026 07:02:11 +0200 Message-ID: <87v7dis20c.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > This commit removes the QemuConsole from the global "consoles" list when > it is finalized. > > Previously, there was a TODO comment indicating this path needed > checking. The assertions added ensure that `dcls`, `gl_block`, and the > `dump_queue` are empty before removal, confirming the console is in a > clean state. > > Fix potential use-after-free crashes when a display console is removed. > > Reported-by: Markus Armbruster > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > ui/console.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ui/console.c b/ui/console.c > index f445db11389..b64e2122f34 100644 > --- a/ui/console.c > +++ b/ui/console.c > @@ -394,10 +394,13 @@ qemu_console_finalize(Object *obj) > { > QemuConsole *c =3D QEMU_CONSOLE(obj); >=20=20 > - /* TODO: check this code path, and unregister from consoles */ > + assert(c->dcls =3D=3D 0); > + assert(c->gl_block =3D=3D 0); > + assert(qemu_co_queue_empty(&c->dump_queue)); Help me out: what ensures this? > g_clear_pointer(&c->surface, qemu_free_displaysurface); > g_clear_pointer(&c->gl_unblock_timer, timer_free); > g_clear_pointer(&c->ui_timer, timer_free); > + QTAILQ_REMOVE(&consoles, c, next); Is @consoles only accessed from the main thread? > } >=20=20 > static void