Re: [PATCH v5] ALSA: control: Verify put() result when in debug mode

[Takashi Iwai <tiwai@suse.de>]

On Thu, 19 Feb 2026 11:15:41 +0100,
Cezary Rojewski wrote:
> 
> On 2026-02-19 11:09 AM, Takashi Iwai wrote:
> > On Thu, 19 Feb 2026 11:08:12 +0100,
> > Takashi Iwai wrote:
> >> 
> >> On Thu, 19 Feb 2026 10:46:14 +0100,
> >> Cezary Rojewski wrote:
> >>> --- /dev/null
> >>> +++ b/sound/core/control_trace.h
> >>> @@ -0,0 +1,49 @@
> >>> +/* SPDX-License-Identifier: GPL-2.0 */
> >>> +#undef TRACE_SYSTEM
> >>> +#define TRACE_SYSTEM snd_pcm
> >> 
> >> It doesn't look like a right place?
> > 
> > Also, it'd be more helpful if you put example outputs in the
> > description, too.  Then one can have a clue what to look for.
> 
> Agreed, an example in the commit message would be nice.
> 
> In regard to the "trace system", not a fan of adding a new "system"
> just for the sake of a single event.

Why not?  We may extend the tracing of controls, too, and it'll make
easier to enable all tracepoints relevant either for PCM or control.

> If we are going that route, I'd
> rather reword "snd_pcm" to "snd" or something similar. From sound-core
> perspective, I believe there should be 1 directory for the events
> declared in sound/core. The event-names are prefixed already, further
> division looks redundant.

That'll be messy under /sys/kernel/debug/tracing/events/*; it'll
become snd/applptr, snd/hwptr, etc.  So, if we want to consolidate
into a single directory, we need to put "pcm_" prefix again to each.

Or maybe better to use subdirectories "snd/pcm" and "snd/ctl" instead.


thanks,

Takashi