From: Roman Gushchin <roman.gushchin@linux.dev>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Meta kernel team <kernel-team@meta.com>
Subject: Re: [PATCH] memcg: manually uninline __memcg_memory_event
Date: Wed, 22 Oct 2025 11:10:22 -0700 [thread overview]
Message-ID: <87v7k67qpd.fsf@linux.dev> (raw)
In-Reply-To: <3h26sozqgksxn4fvh7i6qjhtbnrtzit6eluyieyhsvycs3fbs5@ddblsq2crkit> (Shakeel Butt's message of "Tue, 21 Oct 2025 18:28:02 -0700")
Shakeel Butt <shakeel.butt@linux.dev> writes:
> On Tue, Oct 21, 2025 at 05:58:00PM -0700, SeongJae Park wrote:
>> On Tue, 21 Oct 2025 16:44:25 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
>>
>> > The function __memcg_memory_event has been unnecessarily marked inline
>> > even when it is not really performance critical. It is usually called
>> > to track extreme conditions. Over the time, it has evolved to include
>> > more functionality and inlining it is causing more harm.
>> >
>> > Before the patch:
>> > $ size mm/memcontrol.o net/ipv4/tcp_input.o net/ipv4/tcp_output.o
>> > text data bss dec hex filename
>> > 35645 10574 4192 50411 c4eb mm/memcontrol.o
>> > 54738 1658 0 56396 dc4c net/ipv4/tcp_input.o
>> > 34644 1065 0 35709 8b7d net/ipv4/tcp_output.o
>> >
>> > After the patch:
>> > $ size mm/memcontrol.o net/ipv4/tcp_input.o net/ipv4/tcp_output.o
>> > text data bss dec hex filename
>> > 35137 10446 4192 49775 c26f mm/memcontrol.o
>> > 54322 1562 0 55884 da4c net/ipv4/tcp_input.o
>> > 34492 1017 0 35509 8ab5 net/ipv4/tcp_output.o
>> >
>> > Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
next prev parent reply other threads:[~2025-10-22 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 23:44 [PATCH] memcg: manually uninline __memcg_memory_event Shakeel Butt
2025-10-22 0:58 ` SeongJae Park
2025-10-22 1:28 ` Shakeel Butt
2025-10-22 2:15 ` SeongJae Park
2025-10-22 18:10 ` Roman Gushchin [this message]
2025-10-23 13:18 ` Michal Hocko
2025-10-23 21:35 ` Shakeel Butt
2025-10-24 6:50 ` Michal Hocko
2025-10-27 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7k67qpd.fsf@linux.dev \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.