Re: [PATCH RFC 00/10] qapi: remove all TARGET_* conditionals from the schema

[Markus Armbruster <armbru@redhat.com>]

Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> On 5/12/25 11:39 AM, Daniel P. Berrangé wrote:
>> On Sat, May 10, 2025 at 11:28:59AM +0200, Markus Armbruster wrote:
>>> PATCH 10 empties out and deletes qapi/machine-target.json.  PATCH 04
>>> empties out qapi/misc-target.json without deleting it.  Missing:
>>>
>>> * Delete qapi/misc-target.json
>>>
>>> * Delete entry F: qapi/machine-target.json in MAINTAINERS
>>>
>>> * Delete dead logic around qapi_specific_outputs in qapi/meson.build
>>>
>>> The latter deserves its own PATCH 11.  Whether to delete the
>>> qapi/*-target.json in the patch that empties the file or in PATCH 11 is
>>> a matter of taste.
>> 
>> FYI, after discussing with Pierrick, I'm going to let him take over
>> work on this patch series to drive it forward to something viable
>> to submit as a non-RFC.

No worries, you're passing them into capable hands.

> Thanks for your work Daniel, I'll continue the effort based on your 
> approach.
>
> Just for information, I'll apply a Signed-off-by with my name to all 
> patches posted (including the ones I won't touch) simply because I use
> git rebase --signoff by default, and don't want to have to do this 
> manually and selectively, as I work with a single master, with stacked 
> branches and update-refs.

We actually expect you to add your S-o-B to patches that go through your
tree whether you changed them or not.