From: Thomas Gleixner <tglx@linutronix.de>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"biju.das.au" <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v6 11/12] irqchip/renesas-rzv2h: Update macros ICU_TSSR_TSSEL_{MASK,PREP}
Date: Mon, 24 Feb 2025 16:53:06 +0100 [thread overview]
Message-ID: <87v7szfifx.ffs@tglx> (raw)
In-Reply-To: <TY3PR01MB11346ECB931169C195A63F49386C02@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On Mon, Feb 24 2025 at 13:59, Biju Das wrote:
>> From: Geert Uytterhoeven <geert@linux-m68k.org>
>> > -#define ICU_TSSR_TSSEL_PREP(tssel, n) ((tssel) << ((n) * 8))
>> > -#define ICU_TSSR_TSSEL_MASK(n) ICU_TSSR_TSSEL_PREP(0x7F, n)
>> > +#define ICU_TSSR_TSSEL_PREP(tssel, n, f_width) ((tssel) << ((n) * (f_width)))
>> > +#define ICU_TSSR_TSSEL_MASK(n, _field_width) \
>>
>> Nit: please use f_width or field_width consistently.
>
> With field_width there was some alignment issue, that is
> the reason it is shortened to f_width.
>
> If there are no other comments for this patch, I will switch using
> field_width in the next version.
If this is the only change, then please just post an updated version of
_this_ patch (11/12) as a reply to the patch itself. No need to resend
the whole series for that cosmetic change,
Thanks,
tglx
next prev parent reply other threads:[~2025-02-24 15:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 13:11 [PATCH v6 00/12] Add Support for RZ/G3E ICU Biju Das
2025-02-24 13:11 ` [PATCH v6 01/12] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/G3E SoC Biju Das
2025-02-26 11:04 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 02/12] irqchip/renesas-rzv2h: Fix wrong variable usage in rzv2h_tint_set_type() Biju Das
2025-02-26 11:04 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 03/12] irqchip/renesas-rzv2h: Drop irqchip from struct rzv2h_icu_priv Biju Das
2025-02-26 11:04 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 04/12] irqchip/renesas-rzv2h: Simplify rzv2h_icu_init() Biju Das
2025-02-26 11:04 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 05/12] irqchip/renesas-rzv2h: Use devm_reset_control_get_exclusive_deasserted() Biju Das
2025-02-26 11:04 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 06/12] irqchip/renesas-rzv2h: Use devm_pm_runtime_enable() Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 07/12] irqchip/renesas-rzv2h: Add struct rzv2h_hw_info with t_offs variable Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 08/12] irqchip/renesas-rzv2h: Add max_tssel variable to struct rzv2h_hw_info Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] irqchip/renesas-rzv2h: Add max_tssel " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 09/12] irqchip/renesas-rzv2h: Add field_width variable " Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] irqchip/renesas-rzv2h: Add field_width " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 10/12] irqchip/renesas-rzv2h: Update TSSR_TIEN macro Biju Das
2025-02-24 13:45 ` Geert Uytterhoeven
2025-02-24 16:47 ` Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 11/12] irqchip/renesas-rzv2h: Update macros ICU_TSSR_TSSEL_{MASK,PREP} Biju Das
2025-02-24 13:51 ` Geert Uytterhoeven
2025-02-24 13:59 ` Biju Das
2025-02-24 15:53 ` Thomas Gleixner [this message]
2025-02-24 16:40 ` Biju Das
2025-02-24 16:51 ` Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] " tip-bot2 for Biju Das
2025-02-24 13:11 ` [PATCH v6 12/12] irqchip/renesas-rzv2h: Add RZ/G3E support Biju Das
2025-02-26 11:03 ` [tip: irq/drivers] " tip-bot2 for Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7szfifx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.