From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 05/23] qapi/schema: add __repr__ to QAPIDoc.Section
Date: Thu, 16 Jan 2025 12:50:51 +0100 [thread overview]
Message-ID: <87v7uf6kpw.fsf@pond.sub.org> (raw)
In-Reply-To: <20250114185840.3058525-6-jsnow@redhat.com> (John Snow's message of "Tue, 14 Jan 2025 13:58:22 -0500")
John Snow <jsnow@redhat.com> writes:
> Makes debugging far more pleasant when you can just print(section) and
> get something reasonable to display.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qapi/parser.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
> index c3004aa70c6..cb259c42a6d 100644
> --- a/scripts/qapi/parser.py
> +++ b/scripts/qapi/parser.py
> @@ -673,6 +673,9 @@ def __init__(
> # section text without tag
> self.text = ''
>
> + def __repr__(self) -> str:
> + return f"<QAPIDoc.Section tag={self.tag!r} text={self.text!r}>"
pylint points out
scripts/qapi/parser.py:677:43: E1101: Instance of 'Section' has no 'tag' member (no-member)
Previous patch renamed it to @kind.
> +
> def append_line(self, line: str) -> None:
> self.text += line + '\n'
next prev parent reply other threads:[~2025-01-16 11:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 18:58 [PATCH v2 00/23] docs: add basic sphinx-domain rST generator to qapidoc John Snow
2025-01-14 18:58 ` [PATCH v2 01/23] docs/qapidoc: support header-less freeform sections John Snow
2025-01-14 18:58 ` [PATCH v2 02/23] qapi/parser: adjust info location for doc body section John Snow
2025-01-14 18:58 ` [PATCH v2 03/23] docs/qapidoc: remove example section support John Snow
2025-01-14 18:58 ` [PATCH v2 04/23] qapi: expand tags to all doc sections John Snow
2025-01-14 18:58 ` [PATCH v2 05/23] qapi/schema: add __repr__ to QAPIDoc.Section John Snow
2025-01-16 11:50 ` Markus Armbruster [this message]
2025-01-16 17:36 ` John Snow
2025-01-14 18:58 ` [PATCH v2 06/23] docs/qapidoc: add transmogrifier stub John Snow
2025-01-14 18:58 ` [PATCH v2 07/23] docs/qapidoc: add transmogrifier class stub John Snow
2025-01-14 18:58 ` [PATCH v2 08/23] docs/qapidoc: add visit_module() method John Snow
2025-01-14 18:58 ` [PATCH v2 09/23] qapi/source: allow multi-line QAPISourceInfo advancing John Snow
2025-01-14 18:58 ` [PATCH v2 10/23] docs/qapidoc: add visit_freeform() method John Snow
2025-01-14 18:58 ` [PATCH v2 11/23] docs/qapidoc: add preamble() method John Snow
2025-01-14 18:58 ` [PATCH v2 12/23] docs/qapidoc: add visit_paragraph() method John Snow
2025-01-14 18:58 ` [PATCH v2 13/23] docs/qapidoc: add visit_errors() method John Snow
2025-01-14 18:58 ` [PATCH v2 14/23] docs/qapidoc: add format_type() method John Snow
2025-01-14 18:58 ` [PATCH v2 15/23] docs/qapidoc: add add_field() and generate_field() helper methods John Snow
2025-01-14 18:58 ` [PATCH v2 16/23] docs/qapidoc: add visit_feature() method John Snow
2025-01-14 18:58 ` [PATCH v2 17/23] docs/qapidoc: prepare to record entity being transmogrified John Snow
2025-01-14 18:58 ` [PATCH v2 18/23] docs/qapidoc: add visit_returns() method John Snow
2025-01-14 18:58 ` [PATCH v2 19/23] docs/qapidoc: add visit_member() method John Snow
2025-01-14 18:58 ` [PATCH v2 20/23] docs/qapidoc: add visit_sections() method John Snow
2025-01-14 18:58 ` [PATCH v2 21/23] docs/qapidoc: add visit_entity() John Snow
2025-01-14 18:58 ` [PATCH v2 22/23] docs/qapidoc: implement transmogrify() method John Snow
2025-01-14 18:58 ` [PATCH v2 23/23] docs/qapidoc: add transmogrifier test document John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7uf6kpw.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.