From: Kalle Valo <kvalo@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Jeff Johnson <jjohnson@kernel.org>,
<linux-wireless@vger.kernel.org>, <ath11k@lists.infradead.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH v2] ath11k: remove error checking for debugfs_create_file()
Date: Mon, 28 Oct 2024 16:02:27 +0200 [thread overview]
Message-ID: <87v7xcgwb0.fsf@kernel.org> (raw)
In-Reply-To: <20241025064235.382-1-thunder.leizhen@huawei.com> (Zhen Lei's message of "Fri, 25 Oct 2024 14:42:35 +0800")
Zhen Lei <thunder.leizhen@huawei.com> writes:
> Driver ath11k can work fine even if the debugfs files fail to be created.
> Therefore, the return value check of debugfs_create_file() should be
> ignored, as it says.
>
> Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Are you just guessing or did you confirm on a real device that ath11k
spectral really works without debugfs?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-10-28 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 6:42 [PATCH v2] ath11k: remove error checking for debugfs_create_file() Zhen Lei
2024-10-28 14:02 ` Kalle Valo [this message]
2024-10-28 14:30 ` Jeff Johnson
2024-10-29 2:05 ` Leizhen (ThunderTown)
2024-10-29 3:41 ` Julian Calaby
2024-10-29 14:27 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7xcgwb0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.