From: Kalle Valo <kvalo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Alper Nebi Yasak" <alpernebiyasak@gmail.com>
Subject: Re: [PATCH] wifi: mt76: do not increase mcu skb refcount if retry is not supported
Date: Tue, 17 Sep 2024 14:18:11 +0300 [thread overview]
Message-ID: <87v7yua5qk.fsf@kernel.org> (raw)
In-Reply-To: <20240917110942.22077-1-nbd@nbd.name> (Felix Fietkau's message of "Tue, 17 Sep 2024 13:09:42 +0200")
Felix Fietkau <nbd@nbd.name> writes:
> If mcu_skb_prepare_msg is not implemented, incrementing skb refcount does not
> work for mcu message retry. In some cases (e.g. on SDIO), shared skbs can trigger
> a BUG_ON, crashing the system.
> Fix this by only incrementing refcount if retry is actually supported.
>
> Fixes: 3688c18b65ae ("wifi: mt76: mt7915: retry mcu messages")
> Reported-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> #KernelCI
> Tested-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
I'll queue this to wireless tree and add:
Closes: https://lore.kernel.org/r/d907b13a-f8be-4cb8-a0bb-560a21278041@notapiano/
Ok?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-17 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 11:09 [PATCH] wifi: mt76: do not increase mcu skb refcount if retry is not supported Felix Fietkau
2024-09-17 11:18 ` Kalle Valo [this message]
2024-09-17 12:10 ` Felix Fietkau
2024-09-18 13:34 ` Kalle Valo
2024-10-22 6:48 ` [PATCH] " Muhammad Usama Anjum
2024-10-22 7:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7yua5qk.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alpernebiyasak@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.