From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/i915: Add a separate defintiion for PIPE_CRC_RES_HSW
Date: Fri, 31 May 2024 16:06:34 +0300 [thread overview]
Message-ID: <87v82udtb9.fsf@intel.com> (raw)
In-Reply-To: <20240531115342.2763-5-ville.syrjala@linux.intel.com>
Subject: *definition
On Fri, 31 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On hsw+ we only have one CRC result registers, instead of the
*register
> five we have on ivb, and some of the others have been repurposed
> to serve other CRC related purposed.
*purposes
>
> Since the hsw+ vs. pre-hsw register operate quite diffently
*differently
> let's add a separate definition for the hsw+ variant to make the
> situation a bit more clear. Also since we only use this from a
> hsw+ codepath there is no real benefit to be had with reusing
> the ivb register definition.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-31 13:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 11:53 [PATCH 0/7] drm/i915: Clean up the CRC registers Ville Syrjala
2024-05-31 11:53 ` [PATCH 1/7] drm/i915: Extract intel_pipe_crc_regs.h Ville Syrjala
2024-05-31 12:57 ` Jani Nikula
2024-05-31 11:53 ` [PATCH 2/7] drm/i915: Switch PIPE_CRC_RES_*_IVB to _MMIO_PIPE() Ville Syrjala
2024-05-31 12:58 ` Jani Nikula
2024-05-31 11:53 ` [PATCH 3/7] drm/i915: Regroup pipe CRC regs Ville Syrjala
2024-05-31 13:03 ` Jani Nikula
2024-05-31 11:53 ` [PATCH 4/7] drm/i915: Add a separate defintiion for PIPE_CRC_RES_HSW Ville Syrjala
2024-05-31 13:06 ` Jani Nikula [this message]
2024-05-31 11:53 ` [PATCH 5/7] drm/i915: Document which platforms have which CRC registers Ville Syrjala
2024-05-31 13:07 ` Jani Nikula
2024-05-31 11:53 ` [PATCH 6/7] drm/i915: Define the PIPE_CRC_EXP registers Ville Syrjala
2024-05-31 18:07 ` Jani Nikula
2024-05-31 11:53 ` [PATCH 7/7] drm/i915: Protect CRC reg macro arguments for consistency Ville Syrjala
2024-05-31 13:00 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Clean up the CRC registers Patchwork
2024-05-31 13:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-31 13:11 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-01 15:55 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v82udtb9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.