From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F267C04FFE for ; Wed, 8 May 2024 06:49:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4b7Q-0001br-Dx; Wed, 08 May 2024 02:49:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4b7N-0001RF-MM for qemu-devel@nongnu.org; Wed, 08 May 2024 02:49:33 -0400 Received: from ik1-413-38519.vs.sakura.ne.jp ([153.127.30.23] helo=sakura.ysato.name) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4b7H-0006Sb-1W for qemu-devel@nongnu.org; Wed, 08 May 2024 02:49:33 -0400 Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 6477B1C00EA; Wed, 8 May 2024 15:49:17 +0900 (JST) Date: Wed, 08 May 2024 15:49:13 +0900 Message-ID: <87v83oer2u.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Richard Henderson Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] target/sh4: Update DisasContextBase.insn_start In-Reply-To: <20240506195506.385921-1-richard.henderson@linaro.org> References: <20240506195506.385921-1-richard.henderson@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=153.127.30.23; envelope-from=ysato@users.sourceforge.jp; helo=sakura.ysato.name X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.259, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 07 May 2024 04:55:06 +0900, Richard Henderson wrote: > > Match the extra inserts of INDEX_op_insn_start, fixing > the db->num_insns != 1 assert in translator_loop. > > Fixes: dcd092a0636 ("accel/tcg: Improve can_do_io management") > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/sh4/translate.c b/target/sh4/translate.c > index e599ab9d1a..b3282f3ac7 100644 > --- a/target/sh4/translate.c > +++ b/target/sh4/translate.c > @@ -2189,6 +2189,7 @@ static void decode_gusa(DisasContext *ctx, CPUSH4State *env) > */ > for (i = 1; i < max_insns; ++i) { > tcg_gen_insn_start(pc + i * 2, ctx->envflags); > + ctx->base.insn_start = tcg_last_op(); > } > } > #endif > -- > 2.34.1 > Reviewed-by: Yoshinori Sato -- Yosinori Sato