All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: deprecate driver date
Date: Mon, 29 Apr 2024 20:53:15 +0300	[thread overview]
Message-ID: <87v8402gz8.fsf@intel.com> (raw)
In-Reply-To: <c6f1677d-6fdd-4a64-9072-5ecf6dae1966@amd.com>

On Mon, 29 Apr 2024, Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
> On 4/29/24 12:43, Jani Nikula wrote:
>> The driver date serves no useful purpose, because it's hardly ever
>> updated. The information is misleading at best.
>> 
>> As described in Documentation/gpu/drm-internals.rst:
>> 
>>    The driver date, formatted as YYYYMMDD, is meant to identify the date
>>    of the latest modification to the driver. However, as most drivers
>>    fail to update it, its value is mostly useless. The DRM core prints it
>>    to the kernel log at initialization time and passes it to userspace
>>    through the DRM_IOCTL_VERSION ioctl.
>> 
>> Stop printing the driver date at init, and start returning the empty
>> string "" as driver date through the DRM_IOCTL_VERSION ioctl.
>> 
>> The driver date initialization in drivers and the struct drm_driver date
>> member can be removed in follow-up.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> I would prefer if it was dropped entirely in this patch, but if you feel
> that would require too much back and forth, I'm okay with what is
> currently proposed.

I can if that's what people prefer, but decided to start with this for
the inevitable discussion before putting in the effort. ;)

> Reviewed-by: Hamza Mahfooz <hamza.mahfooz@amd.com>

Thanks,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2024-04-29 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 16:43 [PATCH] drm: deprecate driver date Jani Nikula
2024-04-29 17:41 ` Hamza Mahfooz
2024-04-29 17:53   ` Jani Nikula [this message]
2024-04-30 13:08     ` Daniel Vetter
2024-04-30 13:38       ` Jani Nikula
2024-04-30 14:15         ` Daniel Vetter
2024-04-30  7:53 ` Simon Ser
2024-04-30  9:08   ` Jani Nikula
2024-04-30  8:55 ` Javier Martinez Canillas
2024-05-08 12:57 ` Jani Nikula
2024-05-09 12:20 ` Steven Price
2024-05-10  9:13   ` Jani Nikula
2024-05-10  9:36     ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8402gz8.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamza.mahfooz@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.