Re: [PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 25 Mar 2024, Maxime Ripard <mripard@kernel.org> wrote:
> Hi,
>
> Jani recently pointed out that the Kconfig symbols are a bit difficult
> to work with at the moment when they depend on each other, and that
> using depends on would be a better idea, but no one really did the work
> so far.
>
> So here it goes :)
>
> It's been tested by comparing the drm-misc-arm, drm-misc-arm64 and
> drm-misc-x86 before and after this series and making sure they are
> identical.
>
> Let me know what you think,
> Maxime

Thanks for doing this, I think this is the right direction!

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

That said, 'make olddefconfig' is bound to drop some previously enabled
configs for people, I think in part due to the renames. For example, all
the CEC stuff and DP aux device got deselected for me. It's possibly
going to lead to some grumbling.


>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> Maxime Ripard (12):
>       drm/display: Make DisplayPort AUX bus Kconfig name consistent
>       drm/display: Make DisplayPort tunnel debug Kconfig name consistent
>       drm/display: Make DisplayPort AUX Chardev Kconfig name consistent
>       drm/display: Make DisplayPort CEC-over-AUX Kconfig name consistent
>       drm/display: Reorder Kconfig symbols
>       drm/display: Make all helpers visible and switch to depends on
>       drm: Switch DRM_DISPLAY_HELPER to depends on
>       drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on
>       drm: Switch DRM_DISPLAY_DP_HELPER to depends on
>       drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on
>       drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on
>       drm/bridge: it6505: Remove useless select
>
>  arch/parisc/configs/generic-32bit_defconfig      |  2 +-
>  drivers/gpu/drm/Kconfig                          |  8 +--
>  drivers/gpu/drm/amd/amdgpu/Kconfig               | 12 +++--
>  drivers/gpu/drm/bridge/Kconfig                   | 29 +++++-----
>  drivers/gpu/drm/bridge/analogix/Kconfig          | 16 +++---
>  drivers/gpu/drm/bridge/cadence/Kconfig           |  8 +--
>  drivers/gpu/drm/bridge/synopsys/Kconfig          |  4 +-
>  drivers/gpu/drm/display/Kconfig                  | 68 ++++++++++++------------
>  drivers/gpu/drm/display/Makefile                 |  6 +--
>  drivers/gpu/drm/display/drm_dp_helper.c          |  2 +-
>  drivers/gpu/drm/display/drm_dp_helper_internal.h |  2 +-
>  drivers/gpu/drm/display/drm_dp_tunnel.c          | 10 ++--
>  drivers/gpu/drm/exynos/Kconfig                   |  4 +-
>  drivers/gpu/drm/i915/Kconfig                     |  8 +--
>  drivers/gpu/drm/i915/Kconfig.debug               |  4 +-
>  drivers/gpu/drm/mediatek/Kconfig                 |  6 +--
>  drivers/gpu/drm/msm/Kconfig                      |  8 +--
>  drivers/gpu/drm/nouveau/Kconfig                  | 10 ++--
>  drivers/gpu/drm/panel/Kconfig                    | 32 +++++------
>  drivers/gpu/drm/radeon/Kconfig                   |  8 +--
>  drivers/gpu/drm/rockchip/Kconfig                 |  8 +--
>  drivers/gpu/drm/tegra/Kconfig                    |  8 +--
>  drivers/gpu/drm/vc4/Kconfig                      | 10 ++--
>  drivers/gpu/drm/xe/Kconfig                       | 13 +++--
>  drivers/gpu/drm/xlnx/Kconfig                     |  8 +--
>  include/drm/display/drm_dp_helper.h              |  2 +-
>  26 files changed, 155 insertions(+), 141 deletions(-)
> ---
> base-commit: 5e842d55bad7794823a50f24fd645b58f2ef93ab
> change-id: 20240325-kms-kconfig-helpers-f94991bdd6fa
>
> Best regards,

-- 
Jani Nikula, Intel