From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:6698:b0:a28:f940:7a27 with SMTP id z24csp2378189ejo; Mon, 8 Jan 2024 08:16:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOM2iEeRFW+tinpKaKw8ScrGFAmPe+sBFiG74vjpcu/wbJIzVFOecxBGakVGsXTW4dcsAe X-Received: by 2002:a05:6214:27cb:b0:680:5f49:6912 with SMTP id ge11-20020a05621427cb00b006805f496912mr3954211qvb.118.1704730585351; Mon, 08 Jan 2024 08:16:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704730585; cv=none; d=google.com; s=arc-20160816; b=bAiToYnO3VzY1/IMRzMN902Cnaf24lYXl4sdz+28FaigqshqT7b2bLZHEnBRzp8901 nDEZ2RuG3JwAaCzKzKShLp4j+UpGwSYCWkW23Wy1ucdqgZGwcfyPW1ehlCAQrJogNS9F B5Afz1ofUuUATaC8Q/zo9YzmDqbcv8hg8gjb6PMbWVFs/fZnccoeVZQSsSlc2y3VvmWW mcoouocUzxf3Er2t5x9G9nem6YT5kVaNcTNTW42XSmyd2bV0QQ5CulLv2F6zGilOFhbr xi6iLSzUK6G+SHuJzN+NJSKHStFaAE1kj6Csm4kddYttbxABJj5y8JNR/KcJ4Op2Pvh+ WalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:dkim-signature; bh=wtJkDedwDHeF/y7ha9RF4keG1FriyOywCLFXDPSGFgg=; fh=vc3qBr0m5waJb/+U5ex5GQwyVg2y4gwRKuqprDBgmls=; b=cYgUBZjAIe8H8oy6ZaH4vies7nO9LbESfH3W99Lfn9n/5l0WcYJyqkF/Ydo6ziPlcM 2Llxm18C4cClEYy2BTDCjrU1r4lM+m2CXunP68NSjPCB7tidWNTg2f8LOlh4aVbG9Opx ShuYHLdvmwlgQtOgRL4Huv1HMpWVwGBvTXBTG7pztORJhYes5tYcDG5zirhNwFotTsnQ TVZ5TBwVor6NXUCiRc83+3Pu/cU+Nyjt67PGwGzN8/Bs2zCfWyFmZgT/Y7dq++trFsXU tKN9FORtAv9QMBp7hLNpqYO/bmwHE91xKFxxzxlBYMlfoujtqAS8FVz7o09mlZ+0Zr4/ DPRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gElPLcuu; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u16-20020a0cf1d0000000b0067eab9e436fsi187533qvl.547.2024.01.08.08.16.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2024 08:16:25 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gElPLcuu; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMsIS-00027V-EX; Mon, 08 Jan 2024 11:16:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMsI9-00023k-8T for qemu-arm@nongnu.org; Mon, 08 Jan 2024 11:16:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMsI1-00065z-Ro for qemu-arm@nongnu.org; Mon, 08 Jan 2024 11:15:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704730548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wtJkDedwDHeF/y7ha9RF4keG1FriyOywCLFXDPSGFgg=; b=gElPLcuuYDkNTB2+SMovuJX7WetFp5xhDRCpcSuPE7z01aheGb1n3a6qJZX7BBk4B55SaY i78lZ2yk2DEHvjXg40z3tH0fAx9/TdQIkeog3WpqHdspw2b/OWzFIYtF8ndmR1dAKjmIy/ QfV5jKkybJCb2W+y+JO68v7bfROnIoU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-Ecuw40gPNEulI4lE6Z1Pvg-1; Mon, 08 Jan 2024 11:15:45 -0500 X-MC-Unique: Ecuw40gPNEulI4lE6Z1Pvg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEEBE85A589; Mon, 8 Jan 2024 16:15:44 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC9045191; Mon, 8 Jan 2024 16:15:44 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A24AA21E680D; Mon, 8 Jan 2024 17:15:43 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: inesvarhol , =?utf-8?Q?In=C3=A8s?= Varhol , Mark Cave-Ayland , Peter Maydell , Eduardo Habkost , Paolo Bonzini , qemu-devel@nongnu.org, Alistair Francis , Arnaud Minier , Laurent Vivier , Thomas Huth , qemu-arm@nongnu.org, Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase In-Reply-To: <805ca196-5464-4023-a1c1-97d5a6699c1b@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 5 Jan 2024 11:19:12 +0100") References: <20231228161944.303768-1-ines.varhol@telecom-paris.fr> <20231228161944.303768-3-ines.varhol@telecom-paris.fr> <61fd13b3-7cc9-4e27-bf91-bd2b4aedf97b@linaro.org> <5f624a13-0ba0-4d9a-8910-2ef1c784a295@linaro.org> <805ca196-5464-4023-a1c1-97d5a6699c1b@linaro.org> Date: Mon, 08 Jan 2024 17:15:43 +0100 Message-ID: <87v883by34.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: zgSrbQeB2xIF Philippe Mathieu-Daud=C3=A9 writes: > On 5/1/24 11:13, Philippe Mathieu-Daud=C3=A9 wrote: >> (+Mark & Eduardo) >> On 4/1/24 14:37, inesvarhol wrote: >>> >>> Le jeudi 4 janvier 2024 =C3=A0 14:05, Philippe Mathieu-Daud=C3=A9 a =C3=A9crit=C2=A0: >>> >>> Hello, >>> >>>>> +static void test_edge_selector(void) >>>>> +{ >>>>> + enable_nvic_irq(EXTI0_IRQ); >>>>> + >>>>> + / Configure EXTI line 0 irq on rising edge */ >>>>> + qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti", >>>> >>>> >>>> Markus, this qtest use seems to expect some stability in QOM path... >>>> >>>> In=C3=A8s, Arnaud, having the SoC unattached is dubious, it belongs to >>>> the machine. >>> >>> Noted, we will fix that. >>> Should we be concerned about the "stability in QOM path" ? >> >> Don't worry about this In=C3=A8s, I wanted to raise Markus attention on = this. >> >> You showed a legit use of stable QOM path, and Markus told me recently >> there is no contract for QOM paths (it shouldn't be considered as a >> stable API). IIRC Markus explanation, "/unattached" container was >> added as a temporary hack to allow migrating QDev objects to QOM (see >> around commit da57febfed "qdev: give all devices a canonical path", >> 11 years ago). I'm not sure the hack was intended to be temporary. Doesn't matter now. The connection between parent and child is a child property of the parent. Like all properties, it has a name. These names are the components of the canonical path. When the code that creates the child makes the connection, it can give the property a sensible name. When it doesn't, we sometimes do it in generic code, using the /machine/unattached orphanage, and a name that contains a counter, like /machine/unattached/device[N] /machine/unattached/non-qdev-gpio[N] The actual name depends on execution order, because the counter value does. Brittle. > Hmm am I getting confused with "/peripheral-anon" (commit 8eb02831af > "dev: add an anonymous peripheral container")? Not the same, but related. Devices added with -device / device_add go into /machine/peripheral/ID when they have id=3DID, else into /machine/peripheral/anon/device[N]. Before the commit you quoted, the latter were orphaned I believe. >> I agree anything under "/unattached" can be expected to be stable >> (but we need a community consensus). Then the big question remaining >> is "can any qom-path out of /unattached be considered stable?" Backwards? Keeping /machine/unattached/FOO[N] stable is harder then the paths the code picks explicitly.