From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C146C41535 for ; Tue, 19 Dec 2023 14:49:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFbOn-0006MY-KQ; Tue, 19 Dec 2023 09:48:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFbOm-0006MP-2A for qemu-devel@nongnu.org; Tue, 19 Dec 2023 09:48:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFbOk-0004uS-6q for qemu-devel@nongnu.org; Tue, 19 Dec 2023 09:48:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702997320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+OcpiBrmgEFvDovVZChCfn6JOg6YSq7f1XgsHSsKhtM=; b=Qr8evyAWPzxRg0AeDi2M+NKRlxT2fGsk+mCOJtkytHc7iCu9PjvPKNZGgE3Xqq7iMfWcQI krw2w99z6QeDUVhfzds4yN61o+Ix99hyDusXkgYy7H7gyPIeaXWD5odAeAUER86LGM92RD XQluhnmmFrRkBXBxFXYUihzDV9n/sOY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-gJpK_QACMeOgcVo8z_3VFQ-1; Tue, 19 Dec 2023 09:48:37 -0500 X-MC-Unique: gJpK_QACMeOgcVo8z_3VFQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3004C101A555; Tue, 19 Dec 2023 14:48:37 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 100751C060AF; Tue, 19 Dec 2023 14:48:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 22E1721E6920; Tue, 19 Dec 2023 15:48:36 +0100 (CET) From: Markus Armbruster To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Michael Roth Subject: Re: [PATCH v2] string-output-visitor: show structs as "" In-Reply-To: <20231212134934.500289-1-stefanha@redhat.com> (Stefan Hajnoczi's message of "Tue, 12 Dec 2023 08:49:34 -0500") References: <20231212134934.500289-1-stefanha@redhat.com> Date: Tue, 19 Dec 2023 15:48:36 +0100 Message-ID: <87v88ujliz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Stefan Hajnoczi writes: > StringOutputVisitor crashes when it visits a struct because > ->start_struct() is NULL. > > Show "" instead of crashing. This is necessary because the > virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce > soon is a list of IOThreadMapping structs. > > This patch is a quick fix to solve the crash, but the long-term solution > is replacing StringOutputVisitor with something that can handle the full > gamut of values in QEMU. > > Cc: Markus Armbruster > Signed-off-by: Stefan Hajnoczi Okay as a stopgap to unblock your virtio-blk-pci work. Suggest you merge this patch together with the patch that needs it. Reviewed-by: Markus Armbruster