From: Kalle Valo <kvalo@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
nbd@nbd.name, sean.wang@mediatek.com, deren.wu@mediatek.com
Subject: Re: [PATCH wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps
Date: Mon, 13 Nov 2023 14:39:00 +0200 [thread overview]
Message-ID: <87v8a5u8t7.fsf@kernel.org> (raw)
In-Reply-To: <ZVIXQx4nb25pO0EP@lore-desk> (Lorenzo Bianconi's message of "Mon, 13 Nov 2023 13:32:03 +0100")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> > Use iftype for interface type switch in mt7925_init_he_caps routine
>> >
>> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver
>> > for mt7925 chips")
>> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>
>> What issue does this fix? In other words, what are the user visible
>> symptoms?
>
> Since we are using i (equal to 8 after the for loop above) instead of iftype
> we are missing some HE capabilities exposed to userspace (we are hitting the
> switch default branch). I agree this is something not so harmful and we can
> apply this fix to Felix's tree instead, up to you.
No no, this is fine for the wireless tree :) I just want to document if
this is fixing a real issue which users can see or just a theoretical
fix you found during code review. It makes handling fixes a lot easier
when we have this documented in the commit message.
No need to resend because of this, I can update the commit log if you
tell me what to add.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-11-13 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 10:06 [PATCH wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps Lorenzo Bianconi
2023-11-13 12:05 ` Kalle Valo
2023-11-13 12:32 ` Lorenzo Bianconi
2023-11-13 12:39 ` Kalle Valo [this message]
2023-11-13 12:41 ` Lorenzo Bianconi
2023-11-14 10:04 ` Kalle Valo
2023-11-14 10:30 ` Lorenzo Bianconi
2023-11-22 15:57 ` [wireless] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8a5u8t7.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=deren.wu@mediatek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.