From: Jani Nikula <jani.nikula@intel.com>
To: Nirmoy Das <nirmoy.das@linux.intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c
Date: Tue, 31 Oct 2023 16:18:25 +0200 [thread overview]
Message-ID: <87v8am50zy.fsf@intel.com> (raw)
In-Reply-To: <a2684135-1bda-f705-8462-11c0122c3bb2@linux.intel.com>
On Tue, 31 Oct 2023, Nirmoy Das <nirmoy.das@linux.intel.com> wrote:
> On 10/31/2023 1:45 PM, Jani Nikula wrote:
>> +void i915_gpu_error_debugfs_register(struct drm_i915_private *i915)
>> +{
>> + struct drm_minor *minor = i915->drm.primary;
>> +
>> + debugfs_create_file("i915_error_state", 0644,
>
> nit: s/0644/S_IRUGO | S_IWUSR
The direction pretty much across the kernel is to go towards octal
permissions because the macros are harder to understand.
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-31 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:45 [Intel-gfx] [PATCH RESEND 1/3] drm/i915: make some error capture functions static Jani Nikula
2023-10-31 12:45 ` [Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c Jani Nikula
2023-10-31 12:59 ` Nirmoy Das
2023-10-31 14:18 ` Jani Nikula [this message]
2023-10-31 16:12 ` Nirmoy Das
2023-10-31 12:45 ` [Intel-gfx] [PATCH RESEND 3/3] drm/i915: move gpu error sysfs " Jani Nikula
2023-10-31 13:04 ` Nirmoy Das
2023-10-31 12:48 ` [Intel-gfx] [PATCH RESEND 1/3] drm/i915: make some error capture functions static Nirmoy Das
2023-11-02 12:23 ` Jani Nikula
2023-10-31 21:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/3] " Patchwork
2023-10-31 21:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-31 21:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-02 9:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8am50zy.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.