Re: [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> On Wed, Oct 18, 2023 at 04:27:31PM -0300, Fabiano Rosas wrote:
>> +/**
>> + * qtest_init_with_env:
>> + * @var: Environment variable from where to take the QEMU binary
>> + * @extra_args: Other arguments to pass to QEMU.  CAUTION: these
>> + * arguments are subject to word splitting and shell evaluation.
>> + *
>> + * Like qtest_init(), but use a different environment variable for the
>> + * QEMU binary.
>> + *
>> + * Returns: #QTestState instance.
>> + */
>> +QTestState *qtest_init_with_env(const char *var, const char *extra_args);
>
> Another way to do is instead of passing over the env var, passing over
> "char *qemu_bin" always, and take qtest_qemu_binary() as default.  Also
> relevant to patch 1.  Not a big deal though, so can be done for later.

Here's an low-hanging fruit if someone's interested. =)

I'll take note and do it when I get the chance after the PR merges
otherwise.

Thanks Peter