From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6082C29B2; Tue, 10 Oct 2023 06:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CBCD9D; Mon, 9 Oct 2023 23:19:57 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 92222C0003; Tue, 10 Oct 2023 06:19:54 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1qq65s-00GDHo-Io; Tue, 10 Oct 2023 08:19:48 +0200 From: Peter Korsgaard To: Greg KH Cc: Javier Carrasco , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> <2023101036-fleshy-dude-aec0@gregkh> Date: Tue, 10 Oct 2023 08:19:48 +0200 In-Reply-To: <2023101036-fleshy-dude-aec0@gregkh> (Greg KH's message of "Tue, 10 Oct 2023 08:00:14 +0200") Message-ID: <87v8bfc83f.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: peter@korsgaard.com X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net >>>>> "Greg" == Greg KH writes: > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. >> >> This error happens because the variable res is not updated if the call >> to dm_read_shared_word returns an error. In this particular case -EPROTO >> was returned and res stayed uninitialized. >> >> This can be avoided by checking the return value of dm_read_shared_word >> and propagating the error if the read operation failed. >> >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 >> >> Signed-off-by: Javier Carrasco >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com >> --- >> Changes in v2: >> - Remove unnecessary 'err == 0' case >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com >> --- >> drivers/net/usb/dm9601.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) > What commit id does this fix? It has been there since the beginning, so: Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver") Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard