From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qnzMC-0000Ea-LT for mharc-qemu-trivial@gnu.org; Wed, 04 Oct 2023 06:43:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnzMA-0000EA-VP for qemu-trivial@nongnu.org; Wed, 04 Oct 2023 06:43:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnzM9-0001Ta-9X for qemu-trivial@nongnu.org; Wed, 04 Oct 2023 06:43:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696416232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g3mrwhcScBtAhNpo9fjnQmCoMx3d94B9gkoZJHO6FPM=; b=d04ZcETg9hdMcsfm3TIGahd/pTjM4jUJwrZE0Bf5TFbx40d5JKAhpKuQqQbFWPURRzveu0 s4rycnN7jvRrGMWNonhG5EJV3VhUSAkesXrqDABwbtzu/2fEtbH/wFpkRLCDDi1AVObTj6 LxnMWSnKpMmOfNNWTC0wszciN0AiOU8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-533-i_UqzP0KPxOIkW-civU1XA-1; Wed, 04 Oct 2023 06:43:49 -0400 X-MC-Unique: i_UqzP0KPxOIkW-civU1XA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 060E5811E7B; Wed, 4 Oct 2023 10:43:49 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D812240C2013; Wed, 4 Oct 2023 10:43:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EF6E521E6904; Wed, 4 Oct 2023 12:43:47 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: qemu-devel@nongnu.org, Gerd Hoffmann , qemu-trivial@nongnu.org Subject: Re: [PATCH] audio/ossaudio: Fix compiler warning with -Wshadow References: <20231004083900.95856-1-thuth@redhat.com> Date: Wed, 04 Oct 2023 12:43:47 +0200 In-Reply-To: <20231004083900.95856-1-thuth@redhat.com> (Thomas Huth's message of "Wed, 4 Oct 2023 10:39:00 +0200") Message-ID: <87v8bmis64.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2023 10:43:55 -0000 Thomas Huth writes: > The "err" variable is only used twice in this code, in a very > local fashion of first assigning it and then checking it in the > next line. So there is no need to declare this variable a second > time in the innermost block, we can re-use the variable that is > declared at the beginning of the function. This fixes the compiler > warning that occurs with "-Wshadow". > > Signed-off-by: Thomas Huth Queued. Thanks!