From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92E3EE7B61B for ; Wed, 4 Oct 2023 13:53:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qo2IX-0008Ho-Oq; Wed, 04 Oct 2023 09:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo2IW-0008Hd-S9 for qemu-devel@nongnu.org; Wed, 04 Oct 2023 09:52:20 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qo2IV-000296-7l for qemu-devel@nongnu.org; Wed, 04 Oct 2023 09:52:20 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9679421846; Wed, 4 Oct 2023 13:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696427537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wftMimQhtViClKd6l/etaEAja3g3eWduKbqhpMLpvyQ=; b=HCZTT08dmsOkR76oRvM5x3dEZG5/ICyS/HNFnNCDQJ4+BDIn4YUlzKr55y6x2LdHtKmMJ4 q21XvGGlau1Dbwa03Q0eVYbrLJ5+dVzRdW+Z3p1gpQR8OPyuC1cU7ORJZ8J+Z6EOlA7H4R WMHJaNePEo42q3PJKv6kVm9ZT+ZqSn0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696427537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wftMimQhtViClKd6l/etaEAja3g3eWduKbqhpMLpvyQ=; b=VWGtIq8VIsoiEOLeMuc7Gwwf/vwxk7hMREFE3hZZ0PxzHh2YfX2FC2n1u5wUJa5o8H++/i 6eAim0V1ZbKiQ1AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27F7E139F9; Wed, 4 Oct 2023 13:52:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dxc5ORBuHWUtZQAAMHmgww (envelope-from ); Wed, 04 Oct 2023 13:52:16 +0000 From: Fabiano Rosas To: Markus Armbruster Cc: Markus Armbruster , qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com, leobras@redhat.com, lizhijian@fujitsu.com, eblake@redhat.com Subject: Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr In-Reply-To: <87y1gihc49.fsf@pond.sub.org> References: <20230928132019.2544702-1-armbru@redhat.com> <20230928132019.2544702-53-armbru@redhat.com> <87msx5yosr.fsf@suse.de> <87y1gihc49.fsf@pond.sub.org> Date: Wed, 04 Oct 2023 10:52:14 -0300 Message-ID: <87v8bmpka9.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> error_report() obeys -msg, reports the current error location if any, >>> and reports to the current monitor if any. Reporting to stderr >>> directly with fprintf() or perror() is wrong, because it loses all >>> this. >>> >>> Fix the offenders. Bonus: resolves a FIXME about problematic use of >>> errno. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> migration/rdma.c | 44 +++++++++++++++++++++----------------------- >>> 1 file changed, 21 insertions(+), 23 deletions(-) >>> >>> diff --git a/migration/rdma.c b/migration/rdma.c >>> index 54b59d12b1..dba0802fca 100644 >>> --- a/migration/rdma.c >>> +++ b/migration/rdma.c >>> @@ -877,12 +877,12 @@ static int qemu_rdma_broken_ipv6_kernel(struct ibv_context *verbs, Error **errp) >>> >>> if (roce_found) { >>> if (ib_found) { >>> - fprintf(stderr, "WARN: migrations may fail:" >>> - " IPv6 over RoCE / iWARP in linux" >>> - " is broken. But since you appear to have a" >>> - " mixed RoCE / IB environment, be sure to only" >>> - " migrate over the IB fabric until the kernel " >>> - " fixes the bug.\n"); >>> + warn_report("WARN: migrations may fail:" >>> + " IPv6 over RoCE / iWARP in linux" >>> + " is broken. But since you appear to have a" >>> + " mixed RoCE / IB environment, be sure to only" >>> + " migrate over the IB fabric until the kernel " >>> + " fixes the bug."); >> >> Won't this become "warning: WARN:"? > > It will. I'll drop the "WARN: " prefix. > >>> } else { >>> error_setg(errp, "RDMA ERROR: " >>> "You only have RoCE / iWARP devices in your systems" >>> @@ -1418,12 +1418,8 @@ static int qemu_rdma_unregister_waiting(RDMAContext *rdma) >>> block->remote_keys[chunk] = 0; >>> >>> if (ret != 0) { >>> - /* >>> - * FIXME perror() is problematic, bcause ibv_dereg_mr() is >>> - * not documented to set errno. Will go away later in >>> - * this series. >>> - */ >>> - perror("unregistration chunk failed"); >>> + error_report("unregistration chunk failed: %s", >>> + strerror(ret)); >> >> Doesn't seem to fix the issue, ret might still not be an errno. Am I >> missing something? > > Yes :) > > ibv_dereg_mr(3) section RETURN VALUE has: > > ibv_dereg_mr() returns 0 on success, or the value of errno on failure > (which indicates the failure reason). > > Clearer now? Yep, thank you.