From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C44EE6447 for ; Fri, 15 Sep 2023 09:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233773AbjIOJWm convert rfc822-to-8bit (ORCPT ); Fri, 15 Sep 2023 05:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233778AbjIOJWD (ORCPT ); Fri, 15 Sep 2023 05:22:03 -0400 Received: from hsmtpd-def.xspmail.jp (hsmtpd-def.xspmail.jp [202.238.198.244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 093152D58 for ; Fri, 15 Sep 2023 02:21:40 -0700 (PDT) X-Country-Code: JP Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by hsmtpd-out-1.asahinet.cluster.xspmail.jp (Halon) with ESMTPA id a7a2f565-24e6-42aa-889d-db3acca378ca; Fri, 15 Sep 2023 18:21:39 +0900 (JST) Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id BD71C1C0113; Fri, 15 Sep 2023 18:21:37 +0900 (JST) Date: Fri, 15 Sep 2023 18:21:36 +0900 Message-ID: <87v8cbu6zj.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de Subject: Re: [RESEND RFC PATCH 03/12] sh: SH4 OF support. In-Reply-To: References: <4a138cf1ff14ff6166a66851db7476096fa3f009.1693444193.git.ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Wed, 13 Sep 2023 21:23:14 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Thu, Aug 31, 2023 at 5:22 AM Yoshinori Sato > wrote: > > - switch generic framework in clock / PCI. > > > > Signed-off-by: Yoshinori Sato > > > --- a/arch/sh/include/asm/io.h > > +++ b/arch/sh/include/asm/io.h > > @@ -292,4 +292,14 @@ static inline void iounmap(volatile void __iomem *addr) { } > > int valid_phys_addr_range(phys_addr_t addr, size_t size); > > int valid_mmap_phys_addr_range(unsigned long pfn, size_t size); > > > > + > > +#ifdef __KERNEL__ > > +#define PCI_IOBASE 0xfe240000UL > > + > > +#define HAVE_ARCH_PIO_SIZE > > +#define PIO_OFFSET PCI_IOBASE > > +#define PIO_MASK 0x3ffffUL > > +#define PIO_RESERVED 0x40000UL > > +#endif /* __KERNEL__ */ > > + > > Since commit b94692e84dccf12d ("sh: add including") > in v6.6-rc1, the new definitions must be inserted higher up, before > the inclusion of , to avoid: > > arch/sh/include/asm/io.h:322: warning: "PCI_IOBASE" redefined > 322 | #define PCI_IOBASE 0xfe240000UL > | > include/asm-generic/io.h:527: note: this is the location of the > previous definition > > > #endif /* __ASM_SH_IO_H */ OK. This has been fixed in the v2 patch. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yosinori Sato