All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Aditya Gupta <adityag@linux.ibm.com>, linuxppc-dev@ozlabs.org
Cc: Sourabh Jain <sourabhjain@linux.ibm.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] powerpc: add `cur_cpu_spec` symbol to vmcoreinfo
Date: Thu, 14 Sep 2023 23:22:01 +1000	[thread overview]
Message-ID: <87v8cc7uva.fsf@mail.lhotse> (raw)
In-Reply-To: <20230911091409.415662-1-adityag@linux.ibm.com>

Aditya Gupta <adityag@linux.ibm.com> writes:
> Presently, while reading a vmcore, makedumpfile uses
> `cur_cpu_spec.mmu_features` to decide whether the crashed system had
> RADIX MMU or not.
>
> Currently, makedumpfile fails to get the `cur_cpu_spec` symbol (unless
> a vmlinux is passed with the `-x` flag to makedumpfile), and hence
> assigns offsets and shifts (such as pgd_offset_l4) incorrecly considering
> MMU to be hash MMU.
>
> Add `cur_cpu_spec` symbol and offset of `mmu_features` in the
> `cpu_spec` struct, to VMCOREINFO, so that the symbol address and offset
> is accessible to makedumpfile, without needing the vmlinux file

This looks fine.

Seems like cpu_features would be needed or at least pretty useful too?

cheers

  parent reply	other threads:[~2023-09-14 13:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11  9:14 [PATCH] powerpc: add `cur_cpu_spec` symbol to vmcoreinfo Aditya Gupta
2023-09-13 12:49 ` Sachin Sant
2023-09-14  6:17   ` Aditya Gupta
2023-09-14 13:22   ` Michael Ellerman
2023-09-14 14:37     ` Sachin Sant
2023-09-15  1:16       ` Michael Ellerman
2023-09-19  9:17         ` Aditya Gupta
2023-09-14 13:22 ` Michael Ellerman [this message]
2023-09-15  6:15   ` Hari Bathini
2023-09-19  9:29   ` Aditya Gupta
2023-09-19 10:07     ` Michael Ellerman
2023-09-20 10:57       ` Aditya Gupta
2023-09-21  9:30 ` Michael Ellerman
2023-09-22  8:24   ` Aditya Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8cc7uva.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=adityag@linux.ibm.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=hbathini@linux.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=sourabhjain@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.