From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Devoogdt <thomas@devoogdt.com>,
Daniel Lang <dalang@gmx.at>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, next] package/llvm-project/compiler-rt: fix circular dependency warning
Date: Tue, 12 Sep 2023 20:28:49 +0200 [thread overview]
Message-ID: <87v8cf5jq6.fsf@48ers.dk> (raw)
In-Reply-To: <20230814112336.GC421096@scaer> (Yann E. MORIN's message of "Mon, 14 Aug 2023 13:23:36 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Thomas, All,
> On 2023-08-14 08:36 +0200, Thomas Devoogdt spake thusly:
>> make[4]: Circular include/sanitizer/allocator_interface.h <- include/sanitizer/allocator_interface.h dependency dropped.
>> make[4]: Circular include/sanitizer/asan_interface.h <- include/sanitizer/asan_interface.h dependency dropped.
> [--SNIP--]
>> It's not clear why this cycle happens,
> Well, it is rather easy to understand:
> - include/CMakeLists.txt unconditionally declares dependency rules
> between header files in ${output_dir} and ${CMAKE_CURRENT_SOURCE_DIR}
> without provision for them to be the same directories;
> - this triggers the above warnings from make, hich arbitrarily breaks
> circular dependencies, which in our case happens to be OK.
> See how I extended the commit log for more details.
> And this is actually a fix for an issue that already happens on master.
> So: applied to master, thanks.
Committed to 2023.02.x and 2023.05.x, thanks. Luckily git is smart
enough to notice that those don't have the llvm-project/ sub directory
and do the right thing.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-12 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 9:04 [Buildroot] [PATCH v1, next] package/llvm-project/compiler-rt: fix build with Ninja Thomas Devoogdt
2023-08-08 9:20 ` Thomas Petazzoni via buildroot
2023-08-08 11:22 ` Thomas Devoogdt
2023-08-08 14:23 ` Thomas Petazzoni via buildroot
2023-08-08 18:02 ` Yann E. MORIN
2023-08-14 6:36 ` [Buildroot] [PATCH v2, next] package/llvm-project/compiler-rt: fix circular dependency warning Thomas Devoogdt
2023-08-14 11:23 ` Yann E. MORIN
2023-09-12 18:28 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8cf5jq6.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=dalang@gmx.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.