From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Breno Leitao <leitao@debian.org>
Cc: sdf@google.com, axboe@kernel.dk, asml.silence@gmail.com,
willemdebruijn.kernel@gmail.com, kuba@kernel.org,
martin.lau@linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
io-uring@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v5 3/8] io_uring/cmd: Pass compat mode in issue_flags
Date: Mon, 11 Sep 2023 11:42:23 -0400 [thread overview]
Message-ID: <87v8cg90o0.fsf@suse.de> (raw)
In-Reply-To: <20230911103407.1393149-4-leitao@debian.org> (Breno Leitao's message of "Mon, 11 Sep 2023 03:34:02 -0700")
Breno Leitao <leitao@debian.org> writes:
> Create a new flag to track if the operation is running compat mode.
> This basically check the context->compat and pass it to the issue_flags,
> so, it could be queried later in the callbacks.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>
> ---
> include/linux/io_uring.h | 1 +
> io_uring/uring_cmd.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h
> index 106cdc55ff3b..bc53b35966ed 100644
> --- a/include/linux/io_uring.h
> +++ b/include/linux/io_uring.h
> @@ -20,6 +20,7 @@ enum io_uring_cmd_flags {
> IO_URING_F_SQE128 = (1 << 8),
> IO_URING_F_CQE32 = (1 << 9),
> IO_URING_F_IOPOLL = (1 << 10),
> + IO_URING_F_COMPAT = (1 << 11),
> };
>
> struct io_uring_cmd {
> diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
> index 537795fddc87..60f843a357e0 100644
> --- a/io_uring/uring_cmd.c
> +++ b/io_uring/uring_cmd.c
> @@ -128,6 +128,8 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
> issue_flags |= IO_URING_F_SQE128;
> if (ctx->flags & IORING_SETUP_CQE32)
> issue_flags |= IO_URING_F_CQE32;
> + if (ctx->compat)
> + issue_flags |= IO_URING_F_COMPAT;
> if (ctx->flags & IORING_SETUP_IOPOLL) {
> if (!file->f_op->uring_cmd_iopoll)
> return -EOPNOTSUPP;
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2023-09-11 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 10:33 [PATCH v5 0/8] io_uring: Initial support for {s,g}etsockopt commands Breno Leitao
2023-09-11 10:34 ` [PATCH v5 1/8] net/socket: Break down __sys_setsockopt Breno Leitao
2023-09-11 10:34 ` [PATCH v5 2/8] net/socket: Break down __sys_getsockopt Breno Leitao
2023-09-12 9:37 ` Paolo Abeni
2023-09-11 10:34 ` [PATCH v5 3/8] io_uring/cmd: Pass compat mode in issue_flags Breno Leitao
2023-09-11 15:42 ` Gabriel Krisman Bertazi [this message]
2023-09-11 10:34 ` [PATCH v5 4/8] selftests/net: Extract uring helpers to be reusable Breno Leitao
2023-09-11 10:34 ` [PATCH v5 5/8] io_uring/cmd: return -EOPNOTSUPP if net is disabled Breno Leitao
2023-09-11 15:53 ` Gabriel Krisman Bertazi
2023-09-11 16:46 ` Breno Leitao
2023-09-12 0:20 ` Gabriel Krisman Bertazi
2023-09-11 10:34 ` [PATCH v5 6/8] io_uring/cmd: Introduce SOCKET_URING_OP_GETSOCKOPT Breno Leitao
2023-09-11 10:34 ` [PATCH v5 7/8] io_uring/cmd: Introduce SOCKET_URING_OP_SETSOCKOPT Breno Leitao
2023-09-11 10:34 ` [PATCH v5 8/8] selftests/bpf/sockopt: Add io_uring support Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8cg90o0.fsf@suse.de \
--to=krisman@suse.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.