From: Thomas Gleixner <tglx@linutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2] genirq: proc: fix a procfs entry leak
Date: Fri, 25 Aug 2023 16:58:26 +0200 [thread overview]
Message-ID: <87v8d3b23x.ffs@tglx> (raw)
In-Reply-To: <CAMRc=MdYteOxy87jdSEvBxnN7tx_J1X2aSsRzKZ6WKL31-ipmA@mail.gmail.com>
On Fri, Aug 25 2023 at 13:01, Bartosz Golaszewski wrote:
> On Fri, Aug 25, 2023 at 10:11 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> I was under the impression that the whole irqnum-to-irq_desc mapping
> was designed to handle this situation on purpose, hence a check for
> !desc and a silent return in free_irq(). If a missing mapping was a
> bug, then it would warrant at least a warning, right?
The check for !desc has nothing to do with the problem you are trying to
solve. There is obviously a valid interrupt descriptor so desc != NULL,
otherwise there would be no procfs entries and no actions, no?
Thanks,
tglx
next prev parent reply other threads:[~2023-08-25 14:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 9:36 [PATCH 0/2] genirq: don't leak handler procfs entries Bartosz Golaszewski
2023-08-14 9:36 ` [PATCH 1/2] genirq: proc: drop unused argument from unregister_handler_proc() Bartosz Golaszewski
2023-08-14 9:36 ` [PATCH 2/2] genirq: proc: fix a procfs entry leak Bartosz Golaszewski
2023-08-24 20:12 ` Thomas Gleixner
2023-08-25 7:36 ` brgl
2023-08-25 8:11 ` Thomas Gleixner
2023-08-25 11:01 ` Bartosz Golaszewski
2023-08-25 14:58 ` Thomas Gleixner [this message]
2023-08-25 17:08 ` Thomas Gleixner
2023-08-25 20:07 ` Bartosz Golaszewski
2023-08-26 15:08 ` Thomas Gleixner
2023-08-28 10:06 ` Bartosz Golaszewski
2023-08-28 12:41 ` Thomas Gleixner
2023-08-28 19:03 ` Bartosz Golaszewski
2023-08-28 21:44 ` Thomas Gleixner
2023-08-29 6:26 ` Bartosz Golaszewski
2023-08-29 9:11 ` Thomas Gleixner
2023-08-29 12:24 ` Bartosz Golaszewski
2023-08-29 20:18 ` Greg Kroah-Hartman
2023-08-29 22:29 ` Thomas Gleixner
2023-09-06 14:54 ` Bartosz Golaszewski
2023-09-12 18:16 ` Thomas Gleixner
2023-09-15 19:50 ` Bartosz Golaszewski
2023-11-13 20:53 ` Bartosz Golaszewski
2023-11-14 12:27 ` Greg Kroah-Hartman
2023-11-14 13:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8d3b23x.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.