All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-xe] [PATCH] drm/xe: Unlink display before turning off irq
Date: Wed, 10 May 2023 16:09:11 +0300	[thread overview]
Message-ID: <87v8h0miyw.fsf@intel.com> (raw)
In-Reply-To: <20230510130004.28490-1-nirmoy.das@intel.com>

On Wed, 10 May 2023, Nirmoy Das <nirmoy.das@intel.com> wrote:
> Unlinking display will lead to guc tlb inval timeout for
> the fbdev vma as irqs are disabled.

fixup to display enabling?

BR,
Jani.

>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 32cc83c43b2a..430bd6eb4053 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -349,9 +349,9 @@ void xe_device_remove(struct xe_device *xe)
>  {
>  	xe_device_remove_display(xe);
>  
> -	xe_irq_shutdown(xe);
> -
>  	xe_display_unlink(xe);
> +
> +	xe_irq_shutdown(xe);
>  }
>  
>  void xe_device_shutdown(struct xe_device *xe)

-- 
Jani Nikula, Intel Open Source Graphics Center

  parent reply	other threads:[~2023-05-10 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 13:00 [Intel-xe] [PATCH] drm/xe: Unlink display before turning off irq Nirmoy Das
2023-05-10 13:03 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-05-10 13:04 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-10 13:08 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-10 13:09 ` Jani Nikula [this message]
2023-05-10 13:18   ` [Intel-xe] [PATCH] " Das, Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8h0miyw.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.