From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD0FDC7619A for ; Wed, 5 Apr 2023 11:34:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 208FF10E8F0; Wed, 5 Apr 2023 11:34:09 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEEBA10E8EA for ; Wed, 5 Apr 2023 11:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=cojBmMloHioOlExpRZ0pZ0OKNDP7IJBzTWpUiWuJsyn9TfTq1VC0aQz0hj1qBg54TXOi2m Ue4X+IIhy7lDkqW/zNhk/1vP92vdMLHjD5Ahauh4ZEPgghGLUsagFEyYIGLPwM9XlbK1nP a0exPMcuhss4ebhUhf/QqD5kNd4gXcY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-JL1Z-s1YN1u2upnI_3vAZg-1; Wed, 05 Apr 2023 07:34:03 -0400 X-MC-Unique: JL1Z-s1YN1u2upnI_3vAZg-1 Received: by mail-wm1-f70.google.com with SMTP id o7-20020a05600c4fc700b003edf85f6bb1so19024803wmq.3 for ; Wed, 05 Apr 2023 04:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694442; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=vaz4sB+3jLg16P/sw/ewawwHQaPReJm10enNEVFMsQzMgCMYUkAy6yjIeC8maVyw12 /Kl/ZuW1B2WcO9fV2WiY1OmAO189GLqrAViYDZLT6oOXelOA0I0FKfu9JhUgoXi8x2hj YW9RWozF5+wuzUYDb/BbXSSREu1iRMZyDoDZ/GL7/mJy7JxQAeiA3t/8jJYKWtTl40BS uvQ605zwZ6joIYSXLwSB7ArH3WmRt3+uanEiP2k0p840G/eZCL9X17dFqqmp6uTJl25h 8WLjteAG3jZOe7xAfSsicoGVJaScGuIn10FtK3hQEbUd+Qjl+/V3w/ovGzJqNUplNVxx aXow== X-Gm-Message-State: AAQBX9dcU8IkNPdgzio0SztXcXR7Pkaj/aUxZU93wVUqTrEk1CuhGuqA rYear7PEPvakYyCSK6aDd6lF6YG2buPBt7oxH9DtVzO3Zu2keuxy8frY7/B2loRDzfMqwfWxN6W WeenplniwfvJ/5bzt8NefZKKwFwm5 X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508286wrp.67.1680694442710; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) X-Google-Smtp-Source: AKy350YUjKA961Ix1B03KyblFGKgk9FaYELj3MXThs4Hw8qWQfuaORfFYONMGsntnJe5AvWYZuwF8A== X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508272wrp.67.1680694442440; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u17-20020adfed51000000b002c6e8af1037sm14710349wro.104.2023.04.05.04.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:34:02 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development In-Reply-To: <20230404201842.567344-5-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-5-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:34:01 +0200 Message-ID: <87v8iabm1i.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 5/8] video/aperture: Move vga handling to pci function X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Daniel Vetter , Helge Deller Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Daniel Vetter writes: > A few reasons for this: > > - It's really the only one where this matters. I tried looking around, > and I didn't find any non-pci vga-compatible controllers for x86 > (since that's the only platform where we had this until a few > patches ago), where a driver participating in the aperture claim > dance would interfere. > > - I also don't expect that any future bus anytime soon will > not just look like pci towards the OS, that's been the case for like > 25+ years by now for practically everything (even non non-x86). > > - Also it's a bit funny if we have one part of the vga removal in the > pci function, and the other in the generic one. > > v2: Rebase. > > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FE6C7619A for ; Wed, 5 Apr 2023 11:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237312AbjDELez (ORCPT ); Wed, 5 Apr 2023 07:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237538AbjDELew (ORCPT ); Wed, 5 Apr 2023 07:34:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF91E1BD7 for ; Wed, 5 Apr 2023 04:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=RDMjBTgdBtqnOTiuirzqkZHhUhdhZuFVUIagDHmYI22DiD4yMunu7FaHJQ9ZiD6bwt/z6m yX+JypsrXC+bqjT2qooTifsaiDQzESL3F3sdBPCHNOF9X0Wx/v8Kjd72wMPYbSd1uaLDLh acAe54bGdLJ3nYk9AAb8ya/NH8EKLm4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-YGluW66GPKqJVYFHNnbR2A-1; Wed, 05 Apr 2023 07:34:03 -0400 X-MC-Unique: YGluW66GPKqJVYFHNnbR2A-1 Received: by mail-wm1-f69.google.com with SMTP id bg33-20020a05600c3ca100b003ef6d684105so14730815wmb.1 for ; Wed, 05 Apr 2023 04:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694442; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=gJNrV6X8kwAsQBNRM0h27O1VL+krwMVhaM3RnFPvk7YLXQ4LAKjnbSERZMKK3DaSCK Wq8xzvanmJMx2XStmAU1asl2kId5GCyuvUojw0MYwk0cBZNJRjcNys4UFmAcAULMKn4l sUQJtVajNhFQoHhy5plCYOKMknvyfMKCc8LrSr9e44A1ZokDH8L7+X02Nj8qmBThWIyb W3rKUUPKf7jSFbRjIBK/km72Pv6eXRYYyms1kG/VeTOB+exjNgqy5fyAUwAVJ2zzqbaa q0U36VUy+6UCKDOprf0QBCkhLowufIYJF2ICG8HSx0DcDoXunvdxYZ/aTaTnxIsUXv3L CtxQ== X-Gm-Message-State: AAQBX9eHAFz+Y30ILCAYclScnlKBYsJUoIcDigopGDyAKZVNehdiBgpp 8D+M0hZe0rD5b3l+WNdwY/SW/NRd74jnMvrtUTFOcpgpw7X6DEUqtPRi7Q9OuXCkXEkda6rnwXN hNLSfzwd0D6u50IdwV69Tbks= X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508285wrp.67.1680694442710; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) X-Google-Smtp-Source: AKy350YUjKA961Ix1B03KyblFGKgk9FaYELj3MXThs4Hw8qWQfuaORfFYONMGsntnJe5AvWYZuwF8A== X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508272wrp.67.1680694442440; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u17-20020adfed51000000b002c6e8af1037sm14710349wro.104.2023.04.05.04.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:34:02 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , Daniel Vetter , Daniel Vetter , Thomas Zimmermann , Helge Deller , linux-fbdev@vger.kernel.org Subject: Re: [PATCH 5/8] video/aperture: Move vga handling to pci function In-Reply-To: <20230404201842.567344-5-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-5-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:34:01 +0200 Message-ID: <87v8iabm1i.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Daniel Vetter writes: > A few reasons for this: > > - It's really the only one where this matters. I tried looking around, > and I didn't find any non-pci vga-compatible controllers for x86 > (since that's the only platform where we had this until a few > patches ago), where a driver participating in the aperture claim > dance would interfere. > > - I also don't expect that any future bus anytime soon will > not just look like pci towards the OS, that's been the case for like > 25+ years by now for practically everything (even non non-x86). > > - Also it's a bit funny if we have one part of the vga removal in the > pci function, and the other in the generic one. > > v2: Rebase. > > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E510C76188 for ; Wed, 5 Apr 2023 11:34:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DA6910E8EA; Wed, 5 Apr 2023 11:34:07 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8C4510E8F0 for ; Wed, 5 Apr 2023 11:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=cojBmMloHioOlExpRZ0pZ0OKNDP7IJBzTWpUiWuJsyn9TfTq1VC0aQz0hj1qBg54TXOi2m Ue4X+IIhy7lDkqW/zNhk/1vP92vdMLHjD5Ahauh4ZEPgghGLUsagFEyYIGLPwM9XlbK1nP a0exPMcuhss4ebhUhf/QqD5kNd4gXcY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-L-a3wDXuPZOqwzORc4fLBQ-1; Wed, 05 Apr 2023 07:34:03 -0400 X-MC-Unique: L-a3wDXuPZOqwzORc4fLBQ-1 Received: by mail-wm1-f69.google.com with SMTP id o28-20020a05600c511c00b003ef69894934so15084616wms.6 for ; Wed, 05 Apr 2023 04:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694442; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tk18jdSB5PL8M24Q9AEmOWNrBMpUmu7JVWWnzwGtR04=; b=3fQ/fX8ZSlMyEUnBtdgtluyD3zReDDbcFsh0yZUKgCXNYQlXfAdPj/MazSv2boLpYZ 3XCHp7Mt+r1m07suOqNvINgSfKs50uezHaZ+Xd+2Jz1htN3kaHQ+GZul+YO2UYPju1fM JWbowHWa4jSRd/JA3Xab3s6iHlKcUUdq33/CjgCxOmFS+q9dX/BmSIpNHLg9rSsPfNtc 6pKdx3pJ2C1u0y+NARWICn9WcBU0PmBZrttL/usT0rCIihKkKjgklva3BfgIbeayf4FE Tz58WFD4zds9df7F34QL8WowOKFASvu/fdWyVf5ehACwY1jQzhbIIihivwNrWb6rGOu0 tPRg== X-Gm-Message-State: AAQBX9cbmOPs3wwtp06s+IjWMsdjM7ZHPtclAjcEoUhvl4KLOHxeFP/j KjtcrktgJYv2jFzukGTitSkWt+V0rjx6LiYhmjzODbCg7zONaDkRUk/aP3wclVXVavk51VyReuF ahWasOMVnO37ofOV9edQLU01u9Gv5 X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508284wrp.67.1680694442710; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) X-Google-Smtp-Source: AKy350YUjKA961Ix1B03KyblFGKgk9FaYELj3MXThs4Hw8qWQfuaORfFYONMGsntnJe5AvWYZuwF8A== X-Received: by 2002:adf:f2d1:0:b0:2cf:f0c3:79ba with SMTP id d17-20020adff2d1000000b002cff0c379bamr3508272wrp.67.1680694442440; Wed, 05 Apr 2023 04:34:02 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u17-20020adfed51000000b002c6e8af1037sm14710349wro.104.2023.04.05.04.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:34:02 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Subject: Re: [PATCH 5/8] video/aperture: Move vga handling to pci function In-Reply-To: <20230404201842.567344-5-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-5-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:34:01 +0200 Message-ID: <87v8iabm1i.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Daniel Vetter , Helge Deller Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Daniel Vetter writes: > A few reasons for this: > > - It's really the only one where this matters. I tried looking around, > and I didn't find any non-pci vga-compatible controllers for x86 > (since that's the only platform where we had this until a few > patches ago), where a driver participating in the aperture claim > dance would interfere. > > - I also don't expect that any future bus anytime soon will > not just look like pci towards the OS, that's been the case for like > 25+ years by now for practically everything (even non non-x86). > > - Also it's a bit funny if we have one part of the vga removal in the > pci function, and the other in the generic one. > > v2: Rebase. > > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat