From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74FD8C74A5B for ; Wed, 29 Mar 2023 06:41:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A81C61F4; Wed, 29 Mar 2023 08:40:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A81C61F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680072061; bh=gTu0GuoEjdR6m8Qo07jnu0pG8jkj9OWaOiEDL2hc780=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=o9jmB7up3ISCdyfAX37rsGJFuZHZSmJ6GJPiqadLb6Z1D4JJIynnu85aW7+vbWJhi E7Ynzv7gogmzeeYfb7XBRqu0jcaVyqZlaXsaiRsVYBLhglqDT8nO34U6PRQkJR79up LLaMNZDeb+VgRKg19EcYxw/IXf7VcneTeXdAQ4xE= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 76B57F80272; Wed, 29 Mar 2023 08:39:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C2CBF80272; Wed, 29 Mar 2023 08:39:43 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7244AF80249 for ; Wed, 29 Mar 2023 08:39:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7244AF80249 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RvmAhff+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=UCQWNX3K Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D89341FE00; Wed, 29 Mar 2023 06:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680071968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xuna5cWaX7XYu3VTh+nPANhfWJqoU3iIpz00/mn1YCY=; b=RvmAhff+BO/yaZpbi3dxyhZRpeXtLtstUbYKXB7EW6ZZ1NR5hwCQpoh5BpXk4Nc0itNVpO l5eegM1PfOiiJ7uMNwt/z7zfSSfpwLl7epgkz75DflzfzVT704rrthgELLiEtwf3VT3s5k enmwFyHWO3n5D5bf/4lqwOY2yOvR5BI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680071968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xuna5cWaX7XYu3VTh+nPANhfWJqoU3iIpz00/mn1YCY=; b=UCQWNX3KCdpZxpHVewHoKkSWuYsF9CARQyHtTnoElMXQ95oI3ICEc15TLnfWFv1+qkJrz3 LQPhpbMfnsix+PCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A7038138FF; Wed, 29 Mar 2023 06:39:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 40P5JyDdI2SPJQAAMHmgww (envelope-from ); Wed, 29 Mar 2023 06:39:28 +0000 Date: Wed, 29 Mar 2023 08:39:28 +0200 Message-ID: <87v8ikoycf.wl-tiwai@suse.de> From: Takashi Iwai To: Tasos Sahanidis Subject: Re: [PATCH] ALSA: ymfpci: Create card with device-managed snd_devm_card_new() In-Reply-To: <20230329032422.170024-1-tasos@tasossah.com> References: <20230329032422.170024-1-tasos@tasossah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: YILVXB5AKBU4RUDAIPQO4SND3XEEC5SK X-Message-ID-Hash: YILVXB5AKBU4RUDAIPQO4SND3XEEC5SK X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, tiwai@suse.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 29 Mar 2023 05:24:22 +0200, Tasos Sahanidis wrote: > > snd_card_ymfpci_remove() was removed in commit c6e6bb5eab74 ("ALSA: > ymfpci: Allocate resources with device-managed APIs"), but the call to > snd_card_new() was not replaced with snd_devm_card_new(). > > Since there was no longer a call to snd_card_free, unloading the module > would eventually result in Oops: > > [697561.532887] BUG: unable to handle page fault for address: ffffffffc0924480 > [697561.532893] #PF: supervisor read access in kernel mode > [697561.532896] #PF: error_code(0x0000) - not-present page > [697561.532899] PGD ae1e15067 P4D ae1e15067 PUD ae1e17067 PMD 11a8f5067 PTE 0 > [697561.532905] Oops: 0000 [#1] PREEMPT SMP NOPTI > [697561.532909] CPU: 21 PID: 5080 Comm: wireplumber Tainted: G W OE 6.2.7 #1 > [697561.532914] Hardware name: System manufacturer System Product Name/TUF GAMING X570-PLUS, BIOS 4408 10/28/2022 > [697561.532916] RIP: 0010:try_module_get.part.0+0x1a/0xe0 > [697561.532924] Code: 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 55 48 89 e5 41 55 41 54 49 89 fc bf 01 00 00 00 e8 56 3c f8 ff <41> 83 3c 24 02 0f 84 96 00 00 00 41 8b 84 24 30 03 00 00 85 c0 0f > [697561.532927] RSP: 0018:ffffbe9b858c3bd8 EFLAGS: 00010246 > [697561.532930] RAX: ffff9815d14f1900 RBX: ffff9815c14e6000 RCX: 0000000000000000 > [697561.532933] RDX: 0000000000000000 RSI: ffffffffc055092c RDI: ffffffffb3778c1a > [697561.532935] RBP: ffffbe9b858c3be8 R08: 0000000000000040 R09: ffff981a1a741380 > [697561.532937] R10: ffffbe9b858c3c80 R11: 00000009d56533a6 R12: ffffffffc0924480 > [697561.532939] R13: ffff9823439d8500 R14: 0000000000000025 R15: ffff9815cd109f80 > [697561.532942] FS: 00007f13084f1f80(0000) GS:ffff9824aef40000(0000) knlGS:0000000000000000 > [697561.532945] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [697561.532947] CR2: ffffffffc0924480 CR3: 0000000145344000 CR4: 0000000000350ee0 > [697561.532949] Call Trace: > [697561.532951] > [697561.532955] try_module_get+0x13/0x30 > [697561.532960] snd_ctl_open+0x61/0x1c0 [snd] > [697561.532976] snd_open+0xb4/0x1e0 [snd] > [697561.532989] chrdev_open+0xc7/0x240 > [697561.532995] ? fsnotify_perm.part.0+0x6e/0x160 > [697561.533000] ? __pfx_chrdev_open+0x10/0x10 > [697561.533005] do_dentry_open+0x169/0x440 > [697561.533009] vfs_open+0x2d/0x40 > [697561.533012] path_openat+0xa9d/0x10d0 > [697561.533017] ? debug_smp_processor_id+0x17/0x20 > [697561.533022] ? trigger_load_balance+0x65/0x370 > [697561.533026] do_filp_open+0xb2/0x160 > [697561.533032] ? _raw_spin_unlock+0x19/0x40 > [697561.533036] ? alloc_fd+0xa9/0x190 > [697561.533040] do_sys_openat2+0x9f/0x160 > [697561.533044] __x64_sys_openat+0x55/0x90 > [697561.533048] do_syscall_64+0x3b/0x90 > [697561.533052] entry_SYSCALL_64_after_hwframe+0x72/0xdc > [697561.533056] RIP: 0033:0x7f1308a40db4 > [697561.533059] Code: 24 20 eb 8f 66 90 44 89 54 24 0c e8 46 68 f8 ff 44 8b 54 24 0c 44 89 e2 48 89 ee 41 89 c0 bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 77 32 44 89 c7 89 44 24 0c e8 78 68 f8 ff 8b 44 > [697561.533062] RSP: 002b:00007ffcce664450 EFLAGS: 00000293 ORIG_RAX: 0000000000000101 > [697561.533066] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f1308a40db4 > [697561.533068] RDX: 0000000000080000 RSI: 00007ffcce664690 RDI: 00000000ffffff9c > [697561.533070] RBP: 00007ffcce664690 R08: 0000000000000000 R09: 0000000000000012 > [697561.533072] R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000080000 > [697561.533074] R13: 00007f13054b069b R14: 0000565209f83200 R15: 0000000000000000 > [697561.533078] > > Fixes: c6e6bb5eab74 ("ALSA: ymfpci: Allocate resources with device-managed APIs") > Signed-off-by: Tasos Sahanidis Thanks, this one is applied to for-linus branch now. Takashi