From: Juan Quintela <quintela@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v1] migration/multifd: correct multifd_send_thread to trace the flags
Date: Thu, 16 Mar 2023 15:33:06 +0100 [thread overview]
Message-ID: <87v8j0lqal.fsf@secure.mitica> (raw)
In-Reply-To: <20230309102956.8030-1-wei.w.wang@intel.com> (Wei Wang's message of "Thu, 9 Mar 2023 18:29:56 +0800")
Wei Wang <wei.w.wang@intel.com> wrote:
> The p->flags could be updated via the send_prepare callback, e.g. OR-ed
> with MULTIFD_FLAG_ZLIB via zlib_send_prepare. Assign p->flags to the
> local "flags" before the send_prepare callback could only get partial of
> p->flags. Fix it by moving the assignment of p->flags to the local flags
> after the callback, so that the correct flags can be traced.
>
> Fixes: ab7cbb0b9a3b ("multifd: Make no compression operations into its own structure")
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Good catch. Thanks.
queued.
prev parent reply other threads:[~2023-03-16 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:29 [PATCH v1] migration/multifd: correct multifd_send_thread to trace the flags Wei Wang
2023-03-16 14:33 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8j0lqal.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.