From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30589C6FD19 for ; Thu, 16 Mar 2023 09:31:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 17EDA111E; Thu, 16 Mar 2023 10:30:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 17EDA111E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678959062; bh=vg+nQ5qTUb5iY5kiTFLuyLsFpxn8tQDXhqnM5h55sZc=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eHMHMicPpNLLDADlRXG2hCfB6vnu/zBIwF+peIJMY+clLPHqqPJaMWRh9xEWm3S0a sa79H060fgpfeun+Me3tvaWJy5S4UwvDfoLWnZnuBYRGZu9HyuJjM5UA/wL2tX0/R/ uIW1tgMsif4uE4xVHqMIajGbWGSPYZ5WQAWFek08= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8D4FCF800C9; Thu, 16 Mar 2023 10:29:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C57BCF80423; Thu, 16 Mar 2023 10:29:44 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5D82FF80272 for ; Thu, 16 Mar 2023 10:29:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5D82FF80272 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M8bXr/p0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6rKlw2Re Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B46A921852; Thu, 16 Mar 2023 09:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678958977; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QurUAm30I5Yi6Kk4+3SaU6oagBb/DXxtu8Cu1rTU19A=; b=M8bXr/p0UbfkHA9ih35j1klIA6wLZkOdXQczP0evLR+8F2YnTg6h5bDZz4r8h4Si43MCei z/lMvlaAOZ3nZbJ6hbyaSH3INpFv3ZePolMj7Sx7y9HFltlm5Xe8Qpj84rhfLfMWQfj97W w/sV7a7sd9faJxUtaKIlaoByaL0kMVo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678958977; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QurUAm30I5Yi6Kk4+3SaU6oagBb/DXxtu8Cu1rTU19A=; b=6rKlw2Recdv+p/2cL/ZhTdZaV9bZdRhp9icelXpPrXt9uCNZbGd2NiDhkmxX/IRa0b4gm5 IWG4YaRK0LQZF0Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DB6B133E0; Thu, 16 Mar 2023 09:29:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oS/SHYHhEmToQgAAMHmgww (envelope-from ); Thu, 16 Mar 2023 09:29:37 +0000 Date: Thu, 16 Mar 2023 10:29:36 +0100 Message-ID: <87v8j1hwn3.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void In-Reply-To: <17d833f6-5e7c-4016-9dd5-0305891fddc2@sirena.org.uk> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <17d833f6-5e7c-4016-9dd5-0305891fddc2@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZA7A66IYZ4W2T5547MPNUOQZOKANTYHF X-Message-ID-Hash: ZA7A66IYZ4W2T5547MPNUOQZOKANTYHF X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Takashi Iwai , Liam Girdwood , alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 15 Mar 2023 18:23:23 +0100, Mark Brown wrote: > > On Wed, Mar 15, 2023 at 04:04:52PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > this series adapts the platform drivers below sound/ to use the .remove_new() > > callback. Compared to the traditional .remove() callback .remove_new() returns > > no value. This is a good thing because the driver core doesn't (and cannot) > > cope for errors during remove. The only effect of a non-zero return value in > > .remove() is that the driver core emits a warning. The device is removed anyhow > > and an early return from .remove() usually yields a resource leak. > > ALSA and ASoC patches generally get applied to separate trees so it's > probably better to send them separately unless there's dependencies. Judging from the small portion of non-ASoC patches in the series and also from the nature of the changes, it's fine to pick up all patches in your tree. thanks, Takashi