From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Andrzej Hajda <andrzej.hajda@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 2/9] drm/i915/display/power: use intel_de_rmw if possible
Date: Thu, 16 Feb 2023 18:27:20 +0200 [thread overview]
Message-ID: <87v8k1zic7.fsf@intel.com> (raw)
In-Reply-To: <Y7cywxMBJPmR/Vfj@intel.com>
On Thu, 05 Jan 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Jan 05, 2023 at 02:10:39PM +0100, Andrzej Hajda wrote:
>> The helper makes the code more compact and readable.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
>> .../drm/i915/display/intel_display_power.c | 49 ++++-------
>> .../i915/display/intel_display_power_well.c | 82 ++++++-------------
>> 2 files changed, 39 insertions(+), 92 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>> index 1a23ecd4623a53..90d7a623d6e3cc 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>> @@ -1260,9 +1260,7 @@ static void hsw_disable_lcpll(struct drm_i915_private *dev_priv,
>> drm_err(&dev_priv->drm, "D_COMP RCOMP still in progress\n");
>>
>> if (allow_power_down) {
>> - val = intel_de_read(dev_priv, LCPLL_CTL);
>> - val |= LCPLL_POWER_DOWN_ALLOW;
>> - intel_de_write(dev_priv, LCPLL_CTL, val);
>> + intel_de_rmw(dev_priv, LCPLL_CTL, 0, LCPLL_POWER_DOWN_ALLOW);
>> intel_de_posting_read(dev_priv, LCPLL_CTL);
>> }
>> }
>> @@ -1306,9 +1304,7 @@ static void hsw_restore_lcpll(struct drm_i915_private *dev_priv)
>> drm_err(&dev_priv->drm, "LCPLL not locked yet\n");
>>
>> if (val & LCPLL_CD_SOURCE_FCLK) {
>> - val = intel_de_read(dev_priv, LCPLL_CTL);
>> - val &= ~LCPLL_CD_SOURCE_FCLK;
>> - intel_de_write(dev_priv, LCPLL_CTL, val);
>> + intel_de_rmw(dev_priv, LCPLL_CTL, LCPLL_CD_SOURCE_FCLK, 0);
>>
>> if (wait_for_us((intel_de_read(dev_priv, LCPLL_CTL) &
>> LCPLL_CD_SOURCE_FCLK_DONE) == 0, 1))
>> @@ -1347,15 +1343,11 @@ static void hsw_restore_lcpll(struct drm_i915_private *dev_priv)
>> */
>> static void hsw_enable_pc8(struct drm_i915_private *dev_priv)
>> {
>> - u32 val;
>> -
>> drm_dbg_kms(&dev_priv->drm, "Enabling package C8+\n");
>>
>> - if (HAS_PCH_LPT_LP(dev_priv)) {
>> - val = intel_de_read(dev_priv, SOUTH_DSPCLK_GATE_D);
>> - val &= ~PCH_LP_PARTITION_LEVEL_DISABLE;
>> - intel_de_write(dev_priv, SOUTH_DSPCLK_GATE_D, val);
>> - }
>> + if (HAS_PCH_LPT_LP(dev_priv))
>> + intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D,
>> + PCH_LP_PARTITION_LEVEL_DISABLE, 0);
>>
>> lpt_disable_clkout_dp(dev_priv);
>> hsw_disable_lcpll(dev_priv, true, true);
>> @@ -1363,25 +1355,21 @@ static void hsw_enable_pc8(struct drm_i915_private *dev_priv)
>>
>> static void hsw_disable_pc8(struct drm_i915_private *dev_priv)
>> {
>> - u32 val;
>> -
>> drm_dbg_kms(&dev_priv->drm, "Disabling package C8+\n");
>>
>> hsw_restore_lcpll(dev_priv);
>> intel_init_pch_refclk(dev_priv);
>>
>> - if (HAS_PCH_LPT_LP(dev_priv)) {
>> - val = intel_de_read(dev_priv, SOUTH_DSPCLK_GATE_D);
>> - val |= PCH_LP_PARTITION_LEVEL_DISABLE;
>> - intel_de_write(dev_priv, SOUTH_DSPCLK_GATE_D, val);
>> - }
>> + if (HAS_PCH_LPT_LP(dev_priv))
>> + intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D,
>> + 0, PCH_LP_PARTITION_LEVEL_DISABLE);
>> }
>>
>> static void intel_pch_reset_handshake(struct drm_i915_private *dev_priv,
>> bool enable)
>> {
>> i915_reg_t reg;
>> - u32 reset_bits, val;
>> + u32 reset_bits;
>>
>> if (IS_IVYBRIDGE(dev_priv)) {
>> reg = GEN7_MSG_CTL;
>> @@ -1394,14 +1382,7 @@ static void intel_pch_reset_handshake(struct drm_i915_private *dev_priv,
>> if (DISPLAY_VER(dev_priv) >= 14)
>> reset_bits |= MTL_RESET_PICA_HANDSHAKE_EN;
>>
>> - val = intel_de_read(dev_priv, reg);
>> -
>> - if (enable)
>> - val |= reset_bits;
>> - else
>> - val &= ~reset_bits;
>> -
>> - intel_de_write(dev_priv, reg, val);
>> + intel_de_rmw(dev_priv, reg, reset_bits, enable ? reset_bits : 0);
>
> I believe we have a risk here since we were only cleaning if not enable.
> But anyway this looks the right thing to do here...
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed everything else in the series *except* this one, because there
was a minor conflict. Please rebase and resend.
Sorry for the delay, and thanks for the patches and review.
BR,
Jani.
>
>
>> }
>>
>> static void skl_display_core_init(struct drm_i915_private *dev_priv,
>> @@ -1618,7 +1599,6 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
>> {
>> struct i915_power_domains *power_domains = &dev_priv->display.power.domains;
>> struct i915_power_well *well;
>> - u32 val;
>>
>> gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
>>
>> @@ -1670,11 +1650,10 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
>> intel_dmc_load_program(dev_priv);
>>
>> /* Wa_14011508470:tgl,dg1,rkl,adl-s,adl-p */
>> - if (DISPLAY_VER(dev_priv) >= 12) {
>> - val = DCPR_CLEAR_MEMSTAT_DIS | DCPR_SEND_RESP_IMM |
>> - DCPR_MASK_LPMODE | DCPR_MASK_MAXLATENCY_MEMUP_CLR;
>> - intel_de_rmw(dev_priv, GEN11_CHICKEN_DCPR_2, 0, val);
>> - }
>> + if (DISPLAY_VER(dev_priv) >= 12)
>> + intel_de_rmw(dev_priv, GEN11_CHICKEN_DCPR_2, 0,
>> + DCPR_CLEAR_MEMSTAT_DIS | DCPR_SEND_RESP_IMM |
>> + DCPR_MASK_LPMODE | DCPR_MASK_MAXLATENCY_MEMUP_CLR);
>>
>> /* Wa_14011503030:xelpd */
>> if (DISPLAY_VER(dev_priv) >= 13)
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.c b/drivers/gpu/drm/i915/display/intel_display_power_well.c
>> index 8710dd41ffd4c6..05b431f968cb49 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_power_well.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_power_well.c
>> @@ -333,7 +333,6 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv,
>> {
>> const struct i915_power_well_regs *regs = power_well->desc->ops->regs;
>> int pw_idx = i915_power_well_instance(power_well)->hsw.idx;
>> - u32 val;
>>
>> if (power_well->desc->has_fuses) {
>> enum skl_power_gate pg;
>> @@ -356,9 +355,7 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv,
>> gen9_wait_for_power_well_fuses(dev_priv, SKL_PG0);
>> }
>>
>> - val = intel_de_read(dev_priv, regs->driver);
>> - intel_de_write(dev_priv, regs->driver,
>> - val | HSW_PWR_WELL_CTL_REQ(pw_idx));
>> + intel_de_rmw(dev_priv, regs->driver, 0, HSW_PWR_WELL_CTL_REQ(pw_idx));
>>
>> hsw_wait_for_power_well_enable(dev_priv, power_well, false);
>>
>> @@ -380,14 +377,11 @@ static void hsw_power_well_disable(struct drm_i915_private *dev_priv,
>> {
>> const struct i915_power_well_regs *regs = power_well->desc->ops->regs;
>> int pw_idx = i915_power_well_instance(power_well)->hsw.idx;
>> - u32 val;
>>
>> hsw_power_well_pre_disable(dev_priv,
>> power_well->desc->irq_pipe_mask);
>>
>> - val = intel_de_read(dev_priv, regs->driver);
>> - intel_de_write(dev_priv, regs->driver,
>> - val & ~HSW_PWR_WELL_CTL_REQ(pw_idx));
>> + intel_de_rmw(dev_priv, regs->driver, HSW_PWR_WELL_CTL_REQ(pw_idx), 0);
>> hsw_wait_for_power_well_disable(dev_priv, power_well);
>> }
>>
>> @@ -398,29 +392,22 @@ icl_combo_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
>> const struct i915_power_well_regs *regs = power_well->desc->ops->regs;
>> int pw_idx = i915_power_well_instance(power_well)->hsw.idx;
>> enum phy phy = icl_aux_pw_to_phy(dev_priv, power_well);
>> - u32 val;
>>
>> drm_WARN_ON(&dev_priv->drm, !IS_ICELAKE(dev_priv));
>>
>> - val = intel_de_read(dev_priv, regs->driver);
>> - intel_de_write(dev_priv, regs->driver,
>> - val | HSW_PWR_WELL_CTL_REQ(pw_idx));
>> + intel_de_rmw(dev_priv, regs->driver, 0, HSW_PWR_WELL_CTL_REQ(pw_idx));
>>
>> - if (DISPLAY_VER(dev_priv) < 12) {
>> - val = intel_de_read(dev_priv, ICL_PORT_CL_DW12(phy));
>> - intel_de_write(dev_priv, ICL_PORT_CL_DW12(phy),
>> - val | ICL_LANE_ENABLE_AUX);
>> - }
>> + if (DISPLAY_VER(dev_priv) < 12)
>> + intel_de_rmw(dev_priv, ICL_PORT_CL_DW12(phy),
>> + 0, ICL_LANE_ENABLE_AUX);
>>
>> hsw_wait_for_power_well_enable(dev_priv, power_well, false);
>>
>> /* Display WA #1178: icl */
>> if (pw_idx >= ICL_PW_CTL_IDX_AUX_A && pw_idx <= ICL_PW_CTL_IDX_AUX_B &&
>> - !intel_bios_is_port_edp(dev_priv, (enum port)phy)) {
>> - val = intel_de_read(dev_priv, ICL_AUX_ANAOVRD1(pw_idx));
>> - val |= ICL_AUX_ANAOVRD1_ENABLE | ICL_AUX_ANAOVRD1_LDO_BYPASS;
>> - intel_de_write(dev_priv, ICL_AUX_ANAOVRD1(pw_idx), val);
>> - }
>> + !intel_bios_is_port_edp(dev_priv, (enum port)phy))
>> + intel_de_rmw(dev_priv, ICL_AUX_ANAOVRD1(pw_idx),
>> + 0, ICL_AUX_ANAOVRD1_ENABLE | ICL_AUX_ANAOVRD1_LDO_BYPASS);
>> }
>>
>> static void
>> @@ -430,17 +417,12 @@ icl_combo_phy_aux_power_well_disable(struct drm_i915_private *dev_priv,
>> const struct i915_power_well_regs *regs = power_well->desc->ops->regs;
>> int pw_idx = i915_power_well_instance(power_well)->hsw.idx;
>> enum phy phy = icl_aux_pw_to_phy(dev_priv, power_well);
>> - u32 val;
>>
>> drm_WARN_ON(&dev_priv->drm, !IS_ICELAKE(dev_priv));
>>
>> - val = intel_de_read(dev_priv, ICL_PORT_CL_DW12(phy));
>> - intel_de_write(dev_priv, ICL_PORT_CL_DW12(phy),
>> - val & ~ICL_LANE_ENABLE_AUX);
>> + intel_de_rmw(dev_priv, ICL_PORT_CL_DW12(phy), ICL_LANE_ENABLE_AUX, 0);
>>
>> - val = intel_de_read(dev_priv, regs->driver);
>> - intel_de_write(dev_priv, regs->driver,
>> - val & ~HSW_PWR_WELL_CTL_REQ(pw_idx));
>> + intel_de_rmw(dev_priv, regs->driver, HSW_PWR_WELL_CTL_REQ(pw_idx), 0);
>>
>> hsw_wait_for_power_well_disable(dev_priv, power_well);
>> }
>> @@ -502,19 +484,15 @@ icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
>> const struct i915_power_well_regs *regs = power_well->desc->ops->regs;
>> bool is_tbt = power_well->desc->is_tc_tbt;
>> bool timeout_expected;
>> - u32 val;
>>
>> icl_tc_port_assert_ref_held(dev_priv, power_well, dig_port);
>>
>> - val = intel_de_read(dev_priv, DP_AUX_CH_CTL(aux_ch));
>> - val &= ~DP_AUX_CH_CTL_TBT_IO;
>> - if (is_tbt)
>> - val |= DP_AUX_CH_CTL_TBT_IO;
>> - intel_de_write(dev_priv, DP_AUX_CH_CTL(aux_ch), val);
>> + intel_de_rmw(dev_priv, DP_AUX_CH_CTL(aux_ch),
>> + DP_AUX_CH_CTL_TBT_IO, is_tbt ? DP_AUX_CH_CTL_TBT_IO : 0);
>>
>> - val = intel_de_read(dev_priv, regs->driver);
>> - intel_de_write(dev_priv, regs->driver,
>> - val | HSW_PWR_WELL_CTL_REQ(i915_power_well_instance(power_well)->hsw.idx));
>> + intel_de_rmw(dev_priv, regs->driver,
>> + 0,
>> + HSW_PWR_WELL_CTL_REQ(i915_power_well_instance(power_well)->hsw.idx));
>>
>> /*
>> * An AUX timeout is expected if the TBT DP tunnel is down,
>> @@ -776,12 +754,8 @@ static void tgl_enable_dc3co(struct drm_i915_private *dev_priv)
>>
>> static void tgl_disable_dc3co(struct drm_i915_private *dev_priv)
>> {
>> - u32 val;
>> -
>> drm_dbg_kms(&dev_priv->drm, "Disabling DC3CO\n");
>> - val = intel_de_read(dev_priv, DC_STATE_EN);
>> - val &= ~DC_STATE_DC3CO_STATUS;
>> - intel_de_write(dev_priv, DC_STATE_EN, val);
>> + intel_de_rmw(dev_priv, DC_STATE_EN, DC_STATE_DC3CO_STATUS, 0);
>> gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
>> /*
>> * Delay of 200us DC3CO Exit time B.Spec 49196
>> @@ -820,8 +794,8 @@ void gen9_enable_dc5(struct drm_i915_private *dev_priv)
>>
>> /* Wa Display #1183: skl,kbl,cfl */
>> if (DISPLAY_VER(dev_priv) == 9 && !IS_BROXTON(dev_priv))
>> - intel_de_write(dev_priv, GEN8_CHICKEN_DCPR_1,
>> - intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
>> + intel_de_rmw(dev_priv, GEN8_CHICKEN_DCPR_1,
>> + 0, SKL_SELECT_ALTERNATE_DC_EXIT);
>>
>> gen9_set_dc_state(dev_priv, DC_STATE_EN_UPTO_DC5);
>> }
>> @@ -847,8 +821,8 @@ void skl_enable_dc6(struct drm_i915_private *dev_priv)
>>
>> /* Wa Display #1183: skl,kbl,cfl */
>> if (DISPLAY_VER(dev_priv) == 9 && !IS_BROXTON(dev_priv))
>> - intel_de_write(dev_priv, GEN8_CHICKEN_DCPR_1,
>> - intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
>> + intel_de_rmw(dev_priv, GEN8_CHICKEN_DCPR_1,
>> + 0, SKL_SELECT_ALTERNATE_DC_EXIT);
>>
>> gen9_set_dc_state(dev_priv, DC_STATE_EN_UPTO_DC6);
>> }
>> @@ -1149,18 +1123,14 @@ static bool vlv_power_well_enabled(struct drm_i915_private *dev_priv,
>>
>> static void vlv_init_display_clock_gating(struct drm_i915_private *dev_priv)
>> {
>> - u32 val;
>> -
>> /*
>> * On driver load, a pipe may be active and driving a DSI display.
>> * Preserve DPOUNIT_CLOCK_GATE_DISABLE to avoid the pipe getting stuck
>> * (and never recovering) in this case. intel_dsi_post_disable() will
>> * clear it when we turn off the display.
>> */
>> - val = intel_de_read(dev_priv, DSPCLK_GATE_D(dev_priv));
>> - val &= DPOUNIT_CLOCK_GATE_DISABLE;
>> - val |= VRHUNIT_CLOCK_GATE_DISABLE;
>> - intel_de_write(dev_priv, DSPCLK_GATE_D(dev_priv), val);
>> + intel_de_rmw(dev_priv, DSPCLK_GATE_D(dev_priv),
>> + ~DPOUNIT_CLOCK_GATE_DISABLE, VRHUNIT_CLOCK_GATE_DISABLE);
>>
>> /*
>> * Disable trickle feed and enable pnd deadline calculation
>> @@ -1276,8 +1246,7 @@ static void vlv_dpio_cmn_power_well_enable(struct drm_i915_private *dev_priv,
>> * both PLLs disabled, or we risk losing DPIO and PLL
>> * synchronization.
>> */
>> - intel_de_write(dev_priv, DPIO_CTL,
>> - intel_de_read(dev_priv, DPIO_CTL) | DPIO_CMNRST);
>> + intel_de_rmw(dev_priv, DPIO_CTL, 0, DPIO_CMNRST);
>> }
>>
>> static void vlv_dpio_cmn_power_well_disable(struct drm_i915_private *dev_priv,
>> @@ -1289,8 +1258,7 @@ static void vlv_dpio_cmn_power_well_disable(struct drm_i915_private *dev_priv,
>> assert_pll_disabled(dev_priv, pipe);
>>
>> /* Assert common reset */
>> - intel_de_write(dev_priv, DPIO_CTL,
>> - intel_de_read(dev_priv, DPIO_CTL) & ~DPIO_CMNRST);
>> + intel_de_rmw(dev_priv, DPIO_CTL, DPIO_CMNRST, 0);
>>
>> vlv_set_power_well(dev_priv, power_well, false);
>> }
>> --
>> 2.34.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-02-16 16:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 13:10 [Intel-gfx] [PATCH v2 1/9] drm/i915/display/core: use intel_de_rmw if possible Andrzej Hajda
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 2/9] drm/i915/display/power: " Andrzej Hajda
2023-01-05 20:27 ` Rodrigo Vivi
2023-02-16 16:27 ` Jani Nikula [this message]
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 3/9] drm/i915/display/dpll: " Andrzej Hajda
2023-01-05 20:32 ` Rodrigo Vivi
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 4/9] drm/i915/display/phys: " Andrzej Hajda
2023-01-06 15:26 ` Rodrigo Vivi
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 5/9] drm/i915/display/pch: " Andrzej Hajda
2023-01-06 15:28 ` Rodrigo Vivi
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 6/9] drm/i915/display/hdmi: " Andrzej Hajda
2023-01-06 15:35 ` Rodrigo Vivi
2023-01-09 10:51 ` Andrzej Hajda
2023-01-09 11:45 ` Jani Nikula
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 7/9] drm/i915/display/panel: use intel_de_rmw if possible in panel related code Andrzej Hajda
2023-01-09 19:22 ` Rodrigo Vivi
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 8/9] drm/i915/display/interfaces: use intel_de_rmw if possible Andrzej Hajda
2023-01-09 19:24 ` Rodrigo Vivi
2023-01-05 13:10 ` [Intel-gfx] [PATCH v2 9/9] drm/i915/display/misc: " Andrzej Hajda
2023-01-09 19:27 ` Rodrigo Vivi
2023-01-10 9:28 ` Andrzej Hajda
2023-01-10 11:36 ` [Intel-gfx] [PATCH v3] " Andrzej Hajda
2023-01-10 16:15 ` Rodrigo Vivi
2023-01-05 20:21 ` [Intel-gfx] [PATCH v2 1/9] drm/i915/display/core: " Rodrigo Vivi
2023-01-09 11:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2) Patchwork
2023-01-09 11:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-09 13:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-10 15:45 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev3) Patchwork
2023-01-11 12:09 ` Andrzej Hajda
2023-01-11 12:12 ` Veesam, RavitejaX
2023-02-06 12:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev4) Patchwork
2023-02-06 16:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8k1zic7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.