All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Wenli Looi <wlooi@ucalgary.ca>
Cc: linux-wireless@vger.kernel.org, Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] ath9k: remove most hidden macro dependencies on ah
Date: Thu, 15 Dec 2022 16:12:46 +0100	[thread overview]
Message-ID: <87v8mcd7kh.fsf@toke.dk> (raw)
In-Reply-To: <c8369317-cf84-f0e3-fe8-9b6e22e43a6a@ucalgary.ca>

Wenli Looi <wlooi@ucalgary.ca> writes:

> Adds an explicit _ah parameter to most macros that previously had a
> hidden dependency on ah. This makes the code more compliant with the
> style guide.
>
> This change does not appear to affect the final binary.
>
> Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>

Thanks for doing the conversion! Confirmed that this does not affect the
generated .text - without patch applied:

$ for f in *.ko; do printf "%-15s: " "$f"; objdump -d $f | sha1sum; done
ath9k_common.ko: c06d542df4af8c0e7508bc6bd31fe4c826d37054  -
ath9k_hw.ko    : 23cf6dd88aa548fa21b724c5e78835481c6c5a80  -
ath9k.ko       : eaeb3016b236aafc06f2397b8e41ba85389085e6  -

after applying & rebuilding:

$ for f in *.ko; do printf "%-15s: " "$f"; objdump -d $f | sha1sum; done
ath9k_common.ko: c06d542df4af8c0e7508bc6bd31fe4c826d37054  -
ath9k_hw.ko    : 23cf6dd88aa548fa21b724c5e78835481c6c5a80  -
ath9k.ko       : eaeb3016b236aafc06f2397b8e41ba85389085e6  -


Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>

  reply	other threads:[~2022-12-15 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  9:02 [PATCH] ath9k: remove most hidden macro dependencies on ah Wenli Looi
2022-12-15 15:12 ` Toke Høiland-Jørgensen [this message]
2022-12-19 19:12   ` Wenli Looi
2022-12-20  5:21     ` Kalle Valo
2022-12-22 17:14 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8mcd7kh.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=wlooi@ucalgary.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.