From: Markus Armbruster <armbru@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: Target-dependent include path, why?
Date: Fri, 09 Dec 2022 09:51:21 +0100 [thread overview]
Message-ID: <87v8mlez92.fsf@pond.sub.org> (raw)
In-Reply-To: <e797bb33-6f27-d20a-6a35-9372366bd4f5@linaro.org> (Richard Henderson's message of "Thu, 8 Dec 2022 23:24:01 -0600")
Richard Henderson <richard.henderson@linaro.org> writes:
> On 12/8/22 23:12, Markus Armbruster wrote:
>> I stumbled over this:
>> ../include/ui/qemu-pixman.h:12:10: fatal error: pixman.h: No such file or directory
>> 12 | #include <pixman.h>
>> | ^~~~~~~~~~
>> Works when included into target-dependent code.
>> Running make -V=1 shows we're passing a number of -I only when compiling
>> target-dependent code, i.e. together with -DNEED_CPU_H:
>> -I/usr/include/pixman-1 -I/usr/include/capstone -I/usr/include/spice-server -I/usr/include/spice-1
>> -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/PCSC
>> -isystem../linux-headers -isystemlinux-headers
>> Why?
>
> Because of where [pixman] is added as a dependency in meson.build.
Is it added where it is for a reason, or is it accidental?
> If you want to use it somewhere new, you've got to move the dependency.
next prev parent reply other threads:[~2022-12-09 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 5:12 Target-dependent include path, why? Markus Armbruster
2022-12-09 5:24 ` Richard Henderson
2022-12-09 7:05 ` Philippe Mathieu-Daudé
2022-12-09 8:51 ` Markus Armbruster [this message]
2022-12-09 15:02 ` Richard Henderson
2022-12-09 15:59 ` Philippe Mathieu-Daudé
2022-12-09 16:48 ` Paolo Bonzini
2022-12-09 16:52 ` Peter Maydell
2022-12-09 17:42 ` Paolo Bonzini
2022-12-09 19:53 ` Peter Maydell
2022-12-09 22:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8mlez92.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.